public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug symtab/17799] New: tracking bug for symbol lookup cache patch
@ 2015-01-05 19:28 dje at google dot com
2015-01-11 20:00 ` [Bug symtab/17799] " xdje42 at gmail dot com
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: dje at google dot com @ 2015-01-05 19:28 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=17799
Bug ID: 17799
Summary: tracking bug for symbol lookup cache patch
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: symtab
Assignee: unassigned at sourceware dot org
Reporter: dje at google dot com
This bug is to track the symbol lookup cache patch.
https://sourceware.org/ml/gdb-patches/2014-12/msg00003.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug symtab/17799] tracking bug for symbol lookup cache patch
2015-01-05 19:28 [Bug symtab/17799] New: tracking bug for symbol lookup cache patch dje at google dot com
@ 2015-01-11 20:00 ` xdje42 at gmail dot com
2015-01-11 23:01 ` xdje42 at gmail dot com
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: xdje42 at gmail dot com @ 2015-01-11 20:00 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=17799
Doug Evans <xdje42 at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |xdje42 at gmail dot com
--- Comment #1 from Doug Evans <xdje42 at gmail dot com> ---
Initial commits:
b2fb95e006c29e2cbe4b30523879fe3640f906ad
400678a494713abf8f7ea2367f213109a2c4b886
d98b9ccbccf36563dad92f6093a93655b38bc51b
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug symtab/17799] tracking bug for symbol lookup cache patch
2015-01-05 19:28 [Bug symtab/17799] New: tracking bug for symbol lookup cache patch dje at google dot com
2015-01-11 20:00 ` [Bug symtab/17799] " xdje42 at gmail dot com
@ 2015-01-11 23:01 ` xdje42 at gmail dot com
2015-01-11 23:02 ` xdje42 at gmail dot com
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: xdje42 at gmail dot com @ 2015-01-11 23:01 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=17799
--- Comment #2 from Doug Evans <xdje42 at gmail dot com> ---
Symbol comparison cleanup:
77087adf50cedf78cc216ac6eb3b2863839d713c
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug symtab/17799] tracking bug for symbol lookup cache patch
2015-01-05 19:28 [Bug symtab/17799] New: tracking bug for symbol lookup cache patch dje at google dot com
2015-01-11 20:00 ` [Bug symtab/17799] " xdje42 at gmail dot com
2015-01-11 23:01 ` xdje42 at gmail dot com
@ 2015-01-11 23:02 ` xdje42 at gmail dot com
2015-01-11 23:22 ` xdje42 at gmail dot com
2023-03-05 23:17 ` tromey at sourceware dot org
4 siblings, 0 replies; 6+ messages in thread
From: xdje42 at gmail dot com @ 2015-01-11 23:02 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=17799
--- Comment #3 from Doug Evans <xdje42 at gmail dot com> ---
Bleah.
breakpoint_re_set is called before observer_notify_new_objfile(NULL)
in clear_symtab_users.
This means that the symbol lookup that breakpoint_re_set does
will get stale data and can cause a gdb crash.
Filing for reference sake.
2015-01-11 Doug Evans <xdje42@gmail.com>
* symfile.c (clear_symtab_users): Call observer_notify_new_objfile
before calling breakpoint_re_set.
diff --git a/gdb/symfile.c b/gdb/symfile.c
index d55e361..3242ba1 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -3027,12 +3027,17 @@ clear_symtab_users (int add_flags)
breakpoint_re_set may try to access the current symtab. */
clear_current_source_symtab_and_line ();
+ /* Notify anyone listening that the previous loaded symtab(s) are invalid.
+ It is important to do this before calling breakpoint_re_set as the latter
+ will try to look up symbols, and for example the symbol cache needs to
+ be flushed first. */
+ observer_notify_new_objfile (NULL);
+
clear_displays ();
if ((add_flags & SYMFILE_DEFER_BP_RESET) == 0)
breakpoint_re_set ();
clear_last_displayed_sal ();
clear_pc_function_cache ();
- observer_notify_new_objfile (NULL);
/* Clear globals which might have pointed into a removed objfile.
FIXME: It's not clear which of these are supposed to persist
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug symtab/17799] tracking bug for symbol lookup cache patch
2015-01-05 19:28 [Bug symtab/17799] New: tracking bug for symbol lookup cache patch dje at google dot com
` (2 preceding siblings ...)
2015-01-11 23:02 ` xdje42 at gmail dot com
@ 2015-01-11 23:22 ` xdje42 at gmail dot com
2023-03-05 23:17 ` tromey at sourceware dot org
4 siblings, 0 replies; 6+ messages in thread
From: xdje42 at gmail dot com @ 2015-01-11 23:22 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=17799
--- Comment #4 from Doug Evans <xdje42 at gmail dot com> ---
Patches temporarily reverted in commit
6a3ca067521821b6c2ad9a836104d11e6dd760cb
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug symtab/17799] tracking bug for symbol lookup cache patch
2015-01-05 19:28 [Bug symtab/17799] New: tracking bug for symbol lookup cache patch dje at google dot com
` (3 preceding siblings ...)
2015-01-11 23:22 ` xdje42 at gmail dot com
@ 2023-03-05 23:17 ` tromey at sourceware dot org
4 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2023-03-05 23:17 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=17799
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE
CC| |tromey at sourceware dot org
--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
The symbol cache has been back for a while now.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-05 23:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-05 19:28 [Bug symtab/17799] New: tracking bug for symbol lookup cache patch dje at google dot com
2015-01-11 20:00 ` [Bug symtab/17799] " xdje42 at gmail dot com
2015-01-11 23:01 ` xdje42 at gmail dot com
2015-01-11 23:02 ` xdje42 at gmail dot com
2015-01-11 23:22 ` xdje42 at gmail dot com
2023-03-05 23:17 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).