[Bug cli/17820] New: set history size unlimited in ~/.gdbinit disables history

[Bug cli/17820] New: set history size unlimited in ~/.gdbinit disables history

[dje at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17820

            Bug ID: 17820
           Summary: set history size unlimited in ~/.gdbinit disables
                    history
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: cli
          Assignee: unassigned at sourceware dot org
          Reporter: dje at google dot com

I have this in my ~/.gdbinit:

set history size unlimited

but I generally always use emacs so I've never noticed this.

It doesn't work because while set_history_size_command knows how to
map "unlimited" (== UINT_MAX) to DTRT, init_history does not, which passes
UINT_MAX to stifle_history, which takes an int, and boom.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/17820] set history size unlimited in ~/.gdbinit disables history

[przemyslaw at pawelczyk dot it]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 3200 bytes --]

https://sourceware.org/bugzilla/show_bug.cgi?id=17820

Przemysław Pawełczyk <przemyslaw at pawelczyk dot it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |przemyslaw at pawelczyk dot it

--- Comment #1 from Przemysław Pawełczyk <przemyslaw at pawelczyk dot it> ---
Just for the record, it's not a recent bug. Problem is present in gdb on debian
jessie (gdb v7.7.1) for instance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
>From gdb-prs-return-17958-listarch-gdb-prs=sources.redhat.com@sourceware.org Sat Apr 25 22:10:36 2015
Return-Path: <gdb-prs-return-17958-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb-prs@sources.redhat.com
Received: (qmail 30757 invoked by alias); 25 Apr 2015 22:10:35 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Delivered-To: mailing list gdb-prs@sourceware.org
Received: (qmail 30736 invoked by uid 48); 25 Apr 2015 22:10:35 -0000
From: "LpSolit at netscape dot net" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug web/18330] New: Upgrade Sourceware Bugzilla to 5.0
Date: Sat, 25 Apr 2015 22:10:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: web
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: LpSolit at netscape dot net
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: LpSolit at netscape dot net
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter attachments.created
Message-ID: <bug-18330-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-q2/txt/msg00152.txt.bz2
Content-length: 660

https://sourceware.org/bugzilla/show_bug.cgi?id\x18330

            Bug ID: 18330
           Summary: Upgrade Sourceware Bugzilla to 5.0
           Product: gdb
           Version: unknown
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: web
          Assignee: LpSolit at netscape dot net
          Reporter: LpSolit at netscape dot net

Created attachment 8271
  --> https://sourceware.org/bugzilla/attachment.cgi?id‚71&actioníit
Sourceware extension for 5.0, v1

Similar to https://gcc.gnu.org/bugzilla/show_bug.cgi?idd968

--
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/17820] set history size unlimited in ~/.gdbinit disables history

[dje at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17820

dje at google dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from dje at google dot com ---
dup of 16999

*** This bug has been marked as a duplicate of bug 16999 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/17820] set history size unlimited in ~/.gdbinit disables history

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17820

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ebfd00d210ca6190239140b250499e194fd5af20

commit ebfd00d210ca6190239140b250499e194fd5af20
Author: Patrick Palka <patrick@parcs.ath.cx>
Date:   Sun Apr 26 14:13:59 2015 -0400

    Fix PR gdb/17820

    This patch is a comprehensive fix for PR 17820 which reports that
    using "set history size unlimited" inside one's gdbinit file doesn't
    really work.

    There are three small changes in this patch.  The most important change
    this patch makes is to decode the argument of the "size" subcommand
    using add_setshow_zuinteger_unlimited_cmd() instead of using
    add_setshow_uinteger_cmd().  The new decoder takes an int * and maps
    unlimited to -1 whereas the old decoder takes an unsigned int * and maps
    unlimited to UINT_MAX.  Using the new decoder simplifies our handling of
    unlimited and makes it easier to interface with readline which itself
    expects a signed-int history size.

    The second change is the factoring of the [stifle|unstifle]_history logic
    into a common function which is now used by both init_history() and
    set_history_size_command().  This is technically the change that fixes
    the PR itself.

    Thirdly, this patch initializes history_size_setshow_var to -2 to mean
    that the variable has not been set yet.  Now init_history() tests for -2
    instead of 0 to determine whether to give the variable a default value.
    This means that having "set history size 0" in one's gdbinit file will
    actually keep the history size at 0 and not reset it to 256.

    gdb/ChangeLog:

        PR gdb/17820
        * top.c (history_size_setshow_var): Change type to signed.
        Initialize to -2.  Update documentation.
        (set_readline_history_size): Define.
        (set_history_size_command): Use it.  Remove logic for handling
        out-of-range sizes.
        (init_history): Use set_readline_history_size().  Test for a
        value of -2 instead of 0 when determining whether to set a
        default history size.
        (init_main): Decode the argument of the "size" command as a
        zuinteger_unlimited.

    gdb/testsuite/ChangeLog:

        PR gdb/17820
        * gdb.base/gdbinit-history.exp: New test.
        * gdb.base/gdbinit-history/unlimited/.gdbinit: New file.
        * gdb.base/gdbinit-history/zero/.gdbinit: New file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/17820] set history size unlimited in ~/.gdbinit disables history

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17820

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2093d2d31460dc351145c4c295ea4a101e0c5aed

commit 2093d2d31460dc351145c4c295ea4a101e0c5aed
Author: Patrick Palka <patrick@parcs.ath.cx>
Date:   Thu Jun 4 10:12:27 2015 -0400

    Don't truncate the history file when history size is unlimited

    We still do not handle "set history size unlimited" correctly.  In
    particular, after writing to the history file, we truncate the history
    even if it is unlimited.

    This patch makes sure that we do not call history_truncate_file() if the
    history is not stifled (i.e. if it's unlimited).  This bug causes the
    history file to be truncated to zero on exit when one has "set history
    size unlimited" in their gdbinit file.  Although this code exists in GDB
    7.8, the bug is masked by a pre-existing bug that's been only fixed in
    GDB 7.9 (PR gdb/17820).

    gdb/ChangeLog:

        * top.c (gdb_safe_append_history): Do not call
        history_truncate_file if the history is not stifled.

    gdb/testsuite/ChangeLog:

        * gdb.base/gdbinit-history.exp: Add test case to check that
        an unlimited history file does not get truncated on exit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.