public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug ada/17853] New: Nothing sets pspace_data->sym_cache?
@ 2015-01-18  4:38 xdje42 at gmail dot com
  2015-01-18  7:25 ` [Bug ada/17853] " xdje42 at gmail dot com
  0 siblings, 1 reply; 2+ messages in thread
From: xdje42 at gmail dot com @ 2015-01-18  4:38 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=17853

            Bug ID: 17853
           Summary: Nothing sets pspace_data->sym_cache?
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ada
          Assignee: unassigned at sourceware dot org
          Reporter: xdje42 at gmail dot com

I think there's a bug in cache invalidation, but my testcase isn't exposing it.
That got me digging into the implementation of ada-lang.c's symbol lookup
cache.

It looks like nothing sets pspace_data->sym_cache.

Presumably, it should be set here.

static struct ada_symbol_cache *
ada_get_symbol_cache (struct program_space *pspace)
{
  struct ada_pspace_data *pspace_data = get_ada_pspace_data (pspace);
  struct ada_symbol_cache *sym_cache = pspace_data->sym_cache;

  if (sym_cache == NULL)
    {
      sym_cache = XCNEW (struct ada_symbol_cache);
      ada_init_symbol_cache (sym_cache);
    }

  return sym_cache;
}

Could be missing something though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug ada/17853] Nothing sets pspace_data->sym_cache?
  2015-01-18  4:38 [Bug ada/17853] New: Nothing sets pspace_data->sym_cache? xdje42 at gmail dot com
@ 2015-01-18  7:25 ` xdje42 at gmail dot com
  0 siblings, 0 replies; 2+ messages in thread
From: xdje42 at gmail dot com @ 2015-01-18  7:25 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=17853

Doug Evans <xdje42 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Doug Evans <xdje42 at gmail dot com> ---
Bleah.
Bugzilla was really slow tonight after I clicked "Submit" I got told the
request timed out.
So I refiled, but evidently even though it told me the request timed out this
still got filed.

Closing this as a dupe of PR 17854.

--- Comment #2 from Doug Evans <xdje42 at gmail dot com> ---
Closing as dupe of 17854.

*** This bug has been marked as a duplicate of bug 17854 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-18  7:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-18  4:38 [Bug ada/17853] New: Nothing sets pspace_data->sym_cache? xdje42 at gmail dot com
2015-01-18  7:25 ` [Bug ada/17853] " xdje42 at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).