public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug remote/17946] New: remote.c:5668 possible bad if test ?
@ 2015-02-09 12:57 dcb314 at hotmail dot com
  2015-02-10  0:02 ` [Bug remote/17946] " cvs-commit at gcc dot gnu.org
  2015-02-10 16:45 ` sergiodj at redhat dot com
  0 siblings, 2 replies; 3+ messages in thread
From: dcb314 at hotmail dot com @ 2015-02-09 12:57 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=17946

            Bug ID: 17946
           Summary: remote.c:5668 possible bad if test ?
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: remote
          Assignee: unassigned at sourceware dot org
          Reporter: dcb314 at hotmail dot com

[binutils-gdb/gdb/remote.c:5668]: (warning) Char literal compared with pointer
'p'. Did you intend to dereference it?

        if (p == '\0')
          ;

Maybe
        if (*p == '\0')
          ;

was intended.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug remote/17946] remote.c:5668 possible bad if test ?
  2015-02-09 12:57 [Bug remote/17946] New: remote.c:5668 possible bad if test ? dcb314 at hotmail dot com
@ 2015-02-10  0:02 ` cvs-commit at gcc dot gnu.org
  2015-02-10 16:45 ` sergiodj at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-02-10  0:02 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=17946

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Sergio Durigan Junior
<sergiodj@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0b24eb2de5a6dbefe48fd57fcf5d0e7fb24895d4

commit 0b24eb2de5a6dbefe48fd57fcf5d0e7fb24895d4
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date:   Mon Feb 9 18:58:12 2015 -0500

    PR remote/17946: Fix wrong comparison of pointer against char

    We were comparing a pointer against a char on remote.c.  'dcb' filed a
    bug to inform us about that.  I pushed the following patch under the
    obvious rule.

    gdb/ChangeLog:
    2015-02-09  Sergio Durigan Junior  <sergiodj@redhat.com>

        PR remote/17946
        * gdb/remote.c (remote_parse_stop_reply): Fix wrong comparison
        of pointer against char.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug remote/17946] remote.c:5668 possible bad if test ?
  2015-02-09 12:57 [Bug remote/17946] New: remote.c:5668 possible bad if test ? dcb314 at hotmail dot com
  2015-02-10  0:02 ` [Bug remote/17946] " cvs-commit at gcc dot gnu.org
@ 2015-02-10 16:45 ` sergiodj at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: sergiodj at redhat dot com @ 2015-02-10 16:45 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=17946

Sergio Durigan Junior <sergiodj at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |sergiodj at redhat dot com
         Resolution|---                         |FIXED

--- Comment #2 from Sergio Durigan Junior <sergiodj at redhat dot com> ---
Thanks for the report.  The bug has been fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-10  0:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-09 12:57 [Bug remote/17946] New: remote.c:5668 possible bad if test ? dcb314 at hotmail dot com
2015-02-10  0:02 ` [Bug remote/17946] " cvs-commit at gcc dot gnu.org
2015-02-10 16:45 ` sergiodj at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).