public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug compile/17972] New: Double #include
@ 2015-02-13 15:58 dilyan.palauzov at aegee dot org
  2015-02-13 17:05 ` [Bug compile/17972] " xdje42 at gmail dot com
  0 siblings, 1 reply; 2+ messages in thread
From: dilyan.palauzov at aegee dot org @ 2015-02-13 15:58 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=17972

            Bug ID: 17972
           Summary: Double #include
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: compile
          Assignee: unassigned at sourceware dot org
          Reporter: dilyan.palauzov at aegee dot org

deheader -v (git://gitorious.org/deheader/deheader.git) reported, that in the
gdb tree some .c files #include more than once the same .h file:

m32r-tdep.c has more than one inclusion of "objfiles.h"
mi/mi-main.c has more than one inclusion of "inferior.h"
python/py-block.c has more than one inclusion of "symtab.h"
stubs/ia64vms-stub.c has more than one inclusion of <ssdef.h>
testsuite/gdb.threads/create-fail.c has more than one inclusion of <assert.h>
testsuite/gdb.threads/create-fail.c has more than one inclusion of <stdio.h>
testsuite/gdb.threads/fork-thread-pending.c has more than one inclusion of
<unistd.h>
testsuite/gdb.threads/watchpoint-fork-mt.c has more than one inclusion of
<unistd.h>
tui/tui-source.c has more than one inclusion of "symtab.h"

These delay unncessary the compilation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug compile/17972] Double #include
  2015-02-13 15:58 [Bug compile/17972] New: Double #include dilyan.palauzov at aegee dot org
@ 2015-02-13 17:05 ` xdje42 at gmail dot com
  0 siblings, 0 replies; 2+ messages in thread
From: xdje42 at gmail dot com @ 2015-02-13 17:05 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=17972

Doug Evans <xdje42 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xdje42 at gmail dot com

--- Comment #1 from Doug Evans <xdje42 at gmail dot com> ---
I'd be curious if one could see a measurable difference.

Certainly as cleanup it's ok to remove multiple references to a header in the
same file.  Obviously it's not a correctness issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-13 17:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-13 15:58 [Bug compile/17972] New: Double #include dilyan.palauzov at aegee dot org
2015-02-13 17:05 ` [Bug compile/17972] " xdje42 at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).