[Bug server/18081] New: gdbserver's message when providing an unexisting binary could be improved

[Bug server/18081] New: gdbserver's message when providing an unexisting binary could be improved

[simon.marchi at ericsson dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18081

            Bug ID: 18081
           Summary: gdbserver's message when providing an unexisting
                    binary could be improved
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: server
          Assignee: unassigned at sourceware dot org
          Reporter: simon.marchi at ericsson dot com

The beginning is right, but the internal error should probably not be there.

$ ./gdbserver :1234 blah
Process blah created; pid = 16471
Cannot exec blah: No such file or directory.

Child exited with status 127
Killing process(es): 16471
../../../../src/binutils-gdb/gdb/gdbserver/linux-low.c:920: A problem internal
to GDBserver has been detected.
kill_wait_lwp: Assertion `res > 0' failed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/18081] gdbserver's message when providing an unexisting binary could be improved

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18081

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |palves at redhat dot com

--- Comment #1 from Pedro Alves <palves at redhat dot com> ---
> Child exited with status 127
> Killing process(es): 16471
> ../../../../src/binutils-gdb/gdb/gdbserver/linux-low.c:920: A problem internal > to GDBserver has been detected.
> kill_wait_lwp: Assertion `res > 0' failed.

Hmm, I think this is the same as:

 https://sourceware.org/ml/gdb-patches/2015-03/msg00182.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/18081] gdbserver's message when providing an unexisting binary could be improved

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18081

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at sourceware dot org   |palves at redhat dot com

--- Comment #2 from Pedro Alves <palves at redhat dot com> ---
Actually, thinking again, gdbserver shouldn't even be trying to kill that
process.  The bug is a mourn_inferior call is missing.  I'll send out a fix,
along with a test soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/18081] gdbserver's message when providing an unexisting binary could be improved

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18081

--- Comment #3 from Pedro Alves <palves at redhat dot com> ---
Patch posted:
 https://sourceware.org/ml/gdb-patches/2015-04/msg00242.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/18081] gdbserver's message when providing an unexisting binary could be improved

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18081

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=80ad801e90b5bd389ec156d37e28228fcbca128c

commit 80ad801e90b5bd389ec156d37e28228fcbca128c
Author: Pedro Alves <palves@redhat.com>
Date:   Wed May 6 18:50:03 2015 +0100

    PR server/18081: gdbserver crashes when providing an unexisting binary

     $ ./gdbserver :1234 blah
     Process blah created; pid = 16471
     Cannot exec blah: No such file or directory.

     Child exited with status 127
     Killing process(es): 16471
     ../../../../src/binutils-gdb/gdb/gdbserver/linux-low.c:920: A problem
internal to GDBserver has been detected.
     kill_wait_lwp: Assertion `res > 0' failed.

    GDBserver shouldn't even be trying to kill that process.  GDBserver
    kills or detaches from all processes on exit, and due to a missing
    mourn_inferior call, GDBserver tries to kill the process that it had
    already seen exit.

    Tested on x86_64 Fedora 20.  New test included.  I emulated what
    Windows outputs by hacking an error call in linux_create_inferior.

    gdb/gdbserver/ChangeLog:
    2015-05-06  Pedro Alves  <palves@redhat.com>

        PR server/18081
        * server.c (start_inferior): If the process exits, mourn it.

    gdb/testsuite/ChangeLog:
    2015-05-06  Pedro Alves  <palves@redhat.com>

        PR server/18081
        * gdb.server/non-existing-program.exp: New file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/18081] gdbserver's message when providing an unexisting binary could be improved

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18081

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Pedro Alves <palves at redhat dot com> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/18081] gdbserver's message when providing an unexisting binary could be improved

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18081

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.c.kalker at gmail dot com

--- Comment #6 from Pedro Alves <palves at redhat dot com> ---
*** Bug 18405 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.