public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug tui/18311] New: tui_expand_tabs writes past the end of the buffers it allocates
@ 2015-04-23 17:57 eliz at gnu dot org
2015-04-23 18:02 ` [Bug tui/18311] " eliz at gnu dot org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: eliz at gnu dot org @ 2015-04-23 17:57 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18311
Bug ID: 18311
Summary: tui_expand_tabs writes past the end of the buffers it
allocates
Product: gdb
Version: 7.9
Status: NEW
Severity: critical
Priority: P2
Component: tui
Assignee: unassigned at sourceware dot org
Reporter: eliz at gnu dot org
tui_expand_tabs writes past the end of the buffers it allocates
because we forget to zero out col. This results in us adding more
spaces than we need to get aligned, and we write past the end of the
allocated buffer.
This was noticed on Ubuntu Vivid ppc64le, where gdb would SEGV when
using the TUI.
Reported by Anton Blanchard <anton@samba.org>.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tui/18311] tui_expand_tabs writes past the end of the buffers it allocates
2015-04-23 17:57 [Bug tui/18311] New: tui_expand_tabs writes past the end of the buffers it allocates eliz at gnu dot org
@ 2015-04-23 18:02 ` eliz at gnu dot org
2015-04-23 18:03 ` eliz at gnu dot org
2015-04-23 20:46 ` brobecker at gnat dot com
2 siblings, 0 replies; 4+ messages in thread
From: eliz at gnu dot org @ 2015-04-23 18:02 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18311
--- Comment #1 from Eli Zaretskii <eliz at gnu dot org> ---
Created attachment 8263
--> https://sourceware.org/bugzilla/attachment.cgi?id=8263&action=edit
patch used to fix the bug
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tui/18311] tui_expand_tabs writes past the end of the buffers it allocates
2015-04-23 17:57 [Bug tui/18311] New: tui_expand_tabs writes past the end of the buffers it allocates eliz at gnu dot org
2015-04-23 18:02 ` [Bug tui/18311] " eliz at gnu dot org
@ 2015-04-23 18:03 ` eliz at gnu dot org
2015-04-23 20:46 ` brobecker at gnat dot com
2 siblings, 0 replies; 4+ messages in thread
From: eliz at gnu dot org @ 2015-04-23 18:03 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18311
Eli Zaretskii <eliz at gnu dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Eli Zaretskii <eliz at gnu dot org> ---
Fixed with the attached patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tui/18311] tui_expand_tabs writes past the end of the buffers it allocates
2015-04-23 17:57 [Bug tui/18311] New: tui_expand_tabs writes past the end of the buffers it allocates eliz at gnu dot org
2015-04-23 18:02 ` [Bug tui/18311] " eliz at gnu dot org
2015-04-23 18:03 ` eliz at gnu dot org
@ 2015-04-23 20:46 ` brobecker at gnat dot com
2 siblings, 0 replies; 4+ messages in thread
From: brobecker at gnat dot com @ 2015-04-23 20:46 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18311
Joel Brobecker <brobecker at gnat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |brobecker at gnat dot com
--- Comment #3 from Joel Brobecker <brobecker at gnat dot com> ---
URL to discussion on gdb-patches:
https://www.sourceware.org/ml/gdb-patches/2015-03/msg00472.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-23 20:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-23 17:57 [Bug tui/18311] New: tui_expand_tabs writes past the end of the buffers it allocates eliz at gnu dot org
2015-04-23 18:02 ` [Bug tui/18311] " eliz at gnu dot org
2015-04-23 18:03 ` eliz at gnu dot org
2015-04-23 20:46 ` brobecker at gnat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).