[Bug compile/18484] New: Fix crash on cv-qualified self-reference

[Bug compile/18484] New: Fix crash on cv-qualified self-reference

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18484

            Bug ID: 18484
           Summary: Fix crash on cv-qualified self-reference
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: compile
          Assignee: unassigned at sourceware dot org
          Reporter: jan.kratochvil at redhat dot com
  Target Milestone: ---

[patchv2] compile: Fix crash on cv-qualified self-reference
https://sourceware.org/ml/gdb-patches/2015-05/msg00434.html
Message-ID: <20150516132555.GB17266@host1.jankratochvil.net>

compile code struct_object.selffield = &struct_object
./compile/compile-c-types.c:83: internal-error: insert_type: Assertion `add ==
NULL || add->gcc_type == gcc_type' failed.
A problem internal to GDB has been detected,

Fix+testcase is in the mail.

This is not a regression.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug compile/18484] Fix crash on cv-qualified self-reference

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18484

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jan.kratochvil at redhat dot com
           Assignee|unassigned at sourceware dot org   |jan.kratochvil at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug compile/18484] Fix crash on cv-qualified self-reference

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18484

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
This PR will be fixed in GCC:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=commitdiff;h=072dfdba0ea62abb65514cb3a90cdf3868efe286

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug compile/18484] Fix crash on cv-qualified self-reference

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18484

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |---
   Target Milestone|---                         |7.10

--- Comment #2 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
Reopening just for the info message GDB addition patch for 7.10:
[patchv3] compile: Fix crash on cv-qualified self-reference
https://sourceware.org/ml/gdb-patches/2015-07/msg00105.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug compile/18484] Fix crash on cv-qualified self-reference

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18484

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Kratochvil <jkratoch@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=084641963dba63283bf2eca227f4f77c2598b172

commit 084641963dba63283bf2eca227f4f77c2598b172
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Wed Jul 8 14:42:19 2015 +0200

    compile: Warn for old GCC on cv-qualified self-reference

    GDB could:

    compile code struct_object.selffield = &struct_object
    ./compile/compile-c-types.c:83: internal-error: insert_type: Assertion `add
== NULL || add->gcc_type == gcc_type' failed.
    A problem internal to GDB has been detected,
    further debugging may prove unreliable.
    Quit this debugging session? (y or n) FAIL: gdb.compile/compile.exp:
compile code struct_object.selffield = &struct_object (GDB internal
    error)

    The bug was not in GDB but in the GCC part interfacing with GDB.

    Alexandre Oliva has fixed it the right way:
       
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=commitdiff;h=072dfdba0ea62abb65514cb3a90cdf3868efe286
        git://gcc.gnu.org/git/gcc.git
        aoliva/libcp1

    Attaching this GDB testsuite update + info to user s/he should upgrade GCC.
    After Alex upstreams the fix I can update the message to contain the
specific
    GCC release.

    gdb/ChangeLog
    2015-07-08  Jan Kratochvil  <jan.kratochvil@redhat.com>

        PR compile/18484
        * compile/compile-c-types.c (insert_type): Change gdb_assert to error.

    gdb/testsuite/ChangeLog
    2015-07-08  Jan Kratochvil  <jan.kratochvil@redhat.com>

        PR compile/18484
        * gdb.compile/compile.c (struct struct_type): Add volatile to
        selffield's type.
        * gdb.compile/compile.exp
        (compile code struct_object.selffield = &struct_object): Skip further
        struct_object tests if this one xfails.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug compile/18484] Fix crash on cv-qualified self-reference

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18484

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-7.10-branch branch has been updated by Jan Kratochvil
<jkratoch@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=91affdd27ee8e244df417686ead2b546ee1449bf

commit 91affdd27ee8e244df417686ead2b546ee1449bf
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Wed Jul 8 14:42:19 2015 +0200

    compile: Warn for old GCC on cv-qualified self-reference

    GDB could:

    compile code struct_object.selffield = &struct_object
    ./compile/compile-c-types.c:83: internal-error: insert_type: Assertion `add
== NULL || add->gcc_type == gcc_type' failed.
    A problem internal to GDB has been detected,
    further debugging may prove unreliable.
    Quit this debugging session? (y or n) FAIL: gdb.compile/compile.exp:
compile code struct_object.selffield = &struct_object (GDB internal
    error)

    The bug was not in GDB but in the GCC part interfacing with GDB.

    Alexandre Oliva has fixed it the right way:
       
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=commitdiff;h=072dfdba0ea62abb65514cb3a90cdf3868efe286
        git://gcc.gnu.org/git/gcc.git
        aoliva/libcp1

    Attaching this GDB testsuite update + info to user s/he should upgrade GCC.
    After Alex upstreams the fix I can update the message to contain the
specific
    GCC release.

    gdb/ChangeLog
    2015-07-08  Jan Kratochvil  <jan.kratochvil@redhat.com>

        PR compile/18484
        * compile/compile-c-types.c (insert_type): Change gdb_assert to error.

    gdb/testsuite/ChangeLog
    2015-07-08  Jan Kratochvil  <jan.kratochvil@redhat.com>

        PR compile/18484
        * gdb.compile/compile.c (struct struct_type): Add volatile to
        selffield's type.
        * gdb.compile/compile.exp
        (compile code struct_object.selffield = &struct_object): Skip further
        struct_object tests if this one xfails.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug compile/18484] Fix crash on cv-qualified self-reference

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18484

--- Comment #5 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
[commit] [patchv3] compile: Fix crash on cv-qualified self-reference
https://sourceware.org/ml/gdb-patches/2015-07/msg00204.html

GCC fix to be landed later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug compile/18484] Fix crash on cv-qualified self-reference

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18484

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |INVALID

--- Comment #6 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
->GCC

-- 
You are receiving this mail because:
You are on the CC list for the bug.