[Bug gdb/18810] New: internal error in inline_frame_this_id

[Bug gdb/18810] New: internal error in inline_frame_this_id

[sandra at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18810

            Bug ID: 18810
           Summary: internal error in inline_frame_this_id
           Product: gdb
           Version: unknown
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: sandra at codesourcery dot com
  Target Milestone: ---

We have a debug stub that speaks RSP that we use on various bare-metal targets.
 To start running a program from GDB, we typically use a sequence of commands
like:

file a.out
target remote ...
load
continue

But, sometimes the "target remote" command gives an error:

/path/to/gdb/inline-frame.c:168: internal-error: inline_frame_this_id:
Assertion `frame_id_p (*this_id)' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.

What's happening here is that GDB is trying to interpret the target state
reported by the stub in response to the '?' request, in order to print
something about the current stack frame.  But, the stub is reporting whatever
the target was doing when the connection was made, and GDB is interpreting the
reported PC and stack contents against a program that hasn't been loaded or
started to execute yet, and getting quite confused.

Looking at the code for inline_frame_this_id, I think all the assertions it
contains are incorrect.  I think the corresponding sniffer ought to be testing
all those situations up front and rejecting the unwinder as not applicable.  If
that isn't possible, maybe something can catch the error and print some
user-friendly message about a mismatch between the program file and target
state?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/18810] internal error in inline_frame_this_id

[sean.anderson at seco dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18810

Sean Anderson <sean.anderson at seco dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sean.anderson at seco dot com

--- Comment #3 from Sean Anderson <sean.anderson at seco dot com> ---
Hi,

I am experiencing a similar problem when the stack has been corrupted:

$ gdb-multiarch vmlinux
GNU gdb (Ubuntu 9.2-0ubuntu1~20.04) 9.2
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from vmlinux...
gdb$ target extended-remote :3333
Remote debugging using :3333
memtest (size=<optimized out>, start_phys=<optimized out>, pattern=<optimized
out>) at mm/memtest.c:49
49                      *p = pattern;
gdb$ bt
#0  memtest (size=<optimized out>, start_phys=<optimized out>,
pattern=<optimized out>) at mm/memtest.c:49
#1  do_one_pass (end=<optimized out>, start=<optimized out>, pattern=<optimized
out>) at mm/memtest.c:78
#2  early_memtest (/build/gdb-OxeNvS/gdb-9.2/gdb/inline-frame.c:155:
internal-error: void inline_frame_this_id(frame_info*, void**, frame_id*):
Assertion `frame_id_p (*this_id)' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.

This is a bug, please report it.  For instructions, see:
<http://www.gnu.org/software/gdb/bugs/>.

Aborted (core dumped)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/18810] internal error in inline_frame_this_id

[simark at simark dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=18810

Simon Marchi <simark at simark dot ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simark at simark dot ca

--- Comment #4 from Simon Marchi <simark at simark dot ca> ---
(In reply to Sean Anderson from comment #3)
> Hi,
> 
> I am experiencing a similar problem when the stack has been corrupted:
> 
> $ gdb-multiarch vmlinux
> GNU gdb (Ubuntu 9.2-0ubuntu1~20.04) 9.2
> Copyright (C) 2020 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> Type "show copying" and "show warranty" for details.
> This GDB was configured as "x86_64-linux-gnu".
> Type "show configuration" for configuration details.
> For bug reporting instructions, please see:
> <http://www.gnu.org/software/gdb/bugs/>.
> Find the GDB manual and other documentation resources online at:
>     <http://www.gnu.org/software/gdb/documentation/>.
> 
> For help, type "help".
> Type "apropos word" to search for commands related to "word"...
> Reading symbols from vmlinux...
> gdb$ target extended-remote :3333
> Remote debugging using :3333
> memtest (size=<optimized out>, start_phys=<optimized out>,
> pattern=<optimized out>) at mm/memtest.c:49
> 49			*p = pattern;
> gdb$ bt
> #0  memtest (size=<optimized out>, start_phys=<optimized out>,
> pattern=<optimized out>) at mm/memtest.c:49
> #1  do_one_pass (end=<optimized out>, start=<optimized out>,
> pattern=<optimized out>) at mm/memtest.c:78
> #2  early_memtest (/build/gdb-OxeNvS/gdb-9.2/gdb/inline-frame.c:155:
> internal-error: void inline_frame_this_id(frame_info*, void**, frame_id*):
> Assertion `frame_id_p (*this_id)' failed.
> A problem internal to GDB has been detected,
> further debugging may prove unreliable.
> 
> This is a bug, please report it.  For instructions, see:
> <http://www.gnu.org/software/gdb/bugs/>.
> 
> Aborted (core dumped)

Can you please try master + this patch?  It sounds related.

https://sourceware.org/pipermail/gdb-patches/2021-August/181385.html

It might be a bit easier to grab the patch from here:

https://pi.simark.ca/gdb-patches/20210809154122.3468792-1-andrew.burgess@embecosm.com/

-- 
You are receiving this mail because:
You are on the CC list for the bug.