[Bug gdb/18957] New: Error: static declaration of setns follows non-static declaration

[Bug gdb/18957] New: Error: static declaration of setns follows non-static declaration

[dcollinsn at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18957

            Bug ID: 18957
           Summary: Error: static declaration of setns follows non-static
                    declaration
           Product: gdb
           Version: unknown
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: dcollinsn at gmail dot com
  Target Milestone: ---

Greetings,

While compiling GDB 7.10 on the following system:

dcollins@****~$ uname -a
Linux **** 2.6.32-5-686 #1 SMP Tue May 13 16:33:32 UTC 2014 i686 GNU/Linux

With toolchain versions:
GCC 5.2.0
glibc 2.22
binutils 2.25

by executing the following commands:
./Configure && make

I received the following error:

gcc -g -O2   -I. -I. -I./common -I./config
-DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode
-I./../opcodes/.. -I./../readline/.. -I./../zlib -I../bfd -I./../bfd
-I./../include -I../libdecnumber -I./../libdecnumber  -I./gnulib/import
-Ibuild-gnulib/import    -Wall -Wpointer-arith -Wno-unused -Wunused-value
-Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wpointer-sign
-Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type
-Wold-style-declaration -Wold-style-definition -Wformat-nonliteral  -c -o
linux-namespaces.o -MT linux-namespaces.o -MMD -MP -MF
.deps/linux-namespaces.Tpo ./nat/linux-namespaces.c
./nat/linux-namespaces.c:39:1: error: static declaration of ‘setns’ follows
non-static declaration
 setns (int fd, int nstype)
 ^
In file included from /usr/include/sched.h:43:0,
                 from ./nat/linux-namespaces.c:30:
/usr/include/bits/sched.h:91:12: note: previous declaration of ‘setns’ was here
 extern int setns (int __fd, int __nstype) __THROW;
            ^
make[2]: *** [linux-namespaces.o] Error 1
make[2]: Leaving directory `/home/dcollins/gdb-7.10/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `/home/dcollins/gdb-7.10'
make: *** [all] Error 2

Modifying line 38 of gdb/nat/linux-namespaces.c to remove the static
declaration allowed compilation to continue without error. GDB Configure should
determine whether the preexisting setns is declared with or without static and
should follow that convention to prevent this compile error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
>From gdb-prs-return-18580-listarch-gdb-prs=sources.redhat.com@sourceware.org Mon Sep 14 08:28:22 2015
Return-Path: <gdb-prs-return-18580-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb-prs@sources.redhat.com
Received: (qmail 84310 invoked by alias); 14 Sep 2015 08:28:22 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Delivered-To: mailing list gdb-prs@sourceware.org
Received: (qmail 84091 invoked by uid 48); 14 Sep 2015 08:28:21 -0000
From: "qiyao at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/18947] [aarch64]Step into shared library is very slow.
Date: Mon, 14 Sep 2015 08:28:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: qiyao at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: 8.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cc resolution target_milestone
Message-ID: <bug-18947-4717-GdiY07kBbb@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-18947-4717@http.sourceware.org/bugzilla/>
References: <bug-18947-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-q3/txt/msg00284.txt.bz2
Content-length: 640

https://sourceware.org/bugzilla/show_bug.cgi?id\x18947

Yao Qi <qiyao at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |qiyao at gcc dot gnu.org
         Resolution|---                         |FIXED
   Target Milestone|---                         |8.0

--- Comment #3 from Yao Qi <qiyao at gcc dot gnu.org> ---
Patch is pushed in.  Close it.

--
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/18957] Error: static declaration of setns follows non-static declaration

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18957

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-7.10-branch branch has been updated by Gary Benson
<gary@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a8c636cb54328fb9a71dcf27b66a7e7ab5443d88

commit a8c636cb54328fb9a71dcf27b66a7e7ab5443d88
Author: Gary Benson <gbenson@redhat.com>
Date:   Mon Sep 14 11:02:06 2015 +0100

    Fix build issue with nat/linux-namespaces.c

    This commit fixes a build issue on systems with a prototype for setns
    in their header files but no working setns is detected by configure.

    gdb/ChangeLog:

        PR gdb/18957
        * nat/linux-namespaces.c (setns): Rename from this ...
        (do_setns): ... to this.  Support calling setns if it exists.
        (mnsh_handle_setns): Call do_setns.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/18957] Error: static declaration of setns follows non-static declaration

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18957

Gary Benson <gbenson at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |gbenson at redhat dot com
         Resolution|---                         |FIXED

--- Comment #2 from Gary Benson <gbenson at redhat dot com> ---
Hi Dan,

This was fixed in gdb/master but it didn't get pushed to the 7.10 branch.
I've pushed it there now.

Thanks for reporting this.

Cheers,
Gary

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/18957] Error: static declaration of setns follows non-static declaration

[johnsjvi95 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18957

--- Comment #3 from Stewart <johnsjvi95 at gmail dot com> ---
In file included from /usr/include/sched.h:43:0,
                 from ./nat/linux-namespaces.c:30:
/usr/include/bits/sched.h:91:12: note: previous declaration of ‘setns’ was here
 extern int setns (int __fd, int __nstype) __THROW; 
https://worcesterconcrete.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.