public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug symtab/19009] New: unnecessary lookup of minsym within search_symbols
@ 2015-09-25 18:09 dje at google dot com
2015-09-25 18:10 ` [Bug symtab/19009] " dje at google dot com
0 siblings, 1 reply; 2+ messages in thread
From: dje at google dot com @ 2015-09-25 18:09 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=19009
Bug ID: 19009
Summary: unnecessary lookup of minsym within search_symbols
Product: gdb
Version: unknown
Status: NEW
Severity: normal
Priority: P2
Component: symtab
Assignee: unassigned at sourceware dot org
Reporter: dje at google dot com
Target Milestone: ---
Can't remember if I've filed this, and can't find an existing bug, so filing
this so I don't drop it.
search_symbols has this:
if (kind == FUNCTIONS_DOMAIN
=> ? (find_pc_compunit_symtab
(MSYMBOL_VALUE_ADDRESS (objfile, msymbol)) == NULL)
: (lookup_symbol_in_objfile_from_linkage_name
(objfile, MSYMBOL_LINKAGE_NAME (msymbol), VAR_DOMAIN)
== NULL))
and find_pc_compunit_symtab calls find_pc_sect_compunit_symtab which does this:
msymbol = lookup_minimal_symbol_by_pc_section (pc, section);
We already have the minsym, why look it up again?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug symtab/19009] unnecessary lookup of minsym within search_symbols
2015-09-25 18:09 [Bug symtab/19009] New: unnecessary lookup of minsym within search_symbols dje at google dot com
@ 2015-09-25 18:10 ` dje at google dot com
0 siblings, 0 replies; 2+ messages in thread
From: dje at google dot com @ 2015-09-25 18:10 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=19009
dje at google dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |performance
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-25 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-25 18:09 [Bug symtab/19009] New: unnecessary lookup of minsym within search_symbols dje at google dot com
2015-09-25 18:10 ` [Bug symtab/19009] " dje at google dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).