public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug rust/20367] add further Rust demangling
[not found] <bug-20367-4717@http.sourceware.org/bugzilla/>
@ 2023-03-19 15:35 ` tromey at sourceware dot org
2023-03-20 13:53 ` cvs-commit at gcc dot gnu.org
2023-03-20 13:58 ` tromey at sourceware dot org
2 siblings, 0 replies; 3+ messages in thread
From: tromey at sourceware dot org @ 2023-03-19 15:35 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=20367
--- Comment #9 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2023-March/198103.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug rust/20367] add further Rust demangling
[not found] <bug-20367-4717@http.sourceware.org/bugzilla/>
2023-03-19 15:35 ` [Bug rust/20367] add further Rust demangling tromey at sourceware dot org
@ 2023-03-20 13:53 ` cvs-commit at gcc dot gnu.org
2023-03-20 13:58 ` tromey at sourceware dot org
2 siblings, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-03-20 13:53 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=20367
--- Comment #10 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6e7eef72164c00d6a5a7b0bce9fa01f5481f33cb
commit 6e7eef72164c00d6a5a7b0bce9fa01f5481f33cb
Author: Tom Tromey <tom@tromey.com>
Date: Sun Mar 19 09:13:10 2023 -0600
Use rust_demangle to fix a crash
PR rust/30211 points out a crash caused by a particular completion.
This turns out to happen because a Rust minsym winds up in a
C++-specific path in strncmp_iw_with_mode, which ultimately causes the
completer to pass invalid arguments to string::append.
This patch fixes the bug by reordering the language constants so that
Rust comes before C++, and then using rust_demangle. This ensures
that minsyms are correctly marked as "Rust", avoiding this code and
thus the crash.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=20367
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30211
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug rust/20367] add further Rust demangling
[not found] <bug-20367-4717@http.sourceware.org/bugzilla/>
2023-03-19 15:35 ` [Bug rust/20367] add further Rust demangling tromey at sourceware dot org
2023-03-20 13:53 ` cvs-commit at gcc dot gnu.org
@ 2023-03-20 13:58 ` tromey at sourceware dot org
2 siblings, 0 replies; 3+ messages in thread
From: tromey at sourceware dot org @ 2023-03-20 13:58 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=20367
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.1
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #11 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-20 13:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-20367-4717@http.sourceware.org/bugzilla/>
2023-03-19 15:35 ` [Bug rust/20367] add further Rust demangling tromey at sourceware dot org
2023-03-20 13:53 ` cvs-commit at gcc dot gnu.org
2023-03-20 13:58 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).