[Bug mi/20684] MI commands with "--thread X" cause a switch of the user-selected thread

[Bug mi/20684] MI commands with "--thread X" cause a switch of the user-selected thread

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20684

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Burgess <aburgess@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a9c82bc13cf8dd5d9076e746f744ee711eb55507

commit a9c82bc13cf8dd5d9076e746f744ee711eb55507
Author: Jan Vrany <jan.vrany@labware.com>
Date:   Wed Mar 2 13:23:30 2022 +0000

    gdb/mi: preserve user selected thread and frame when invoking MI commands

    Fix for PR gdb/20684.  When invoking MI commands with --thread and/or
    --frame, the user selected thread and frame was not preserved:

      (gdb)
      info thread
      &"info thread\n"
      ~"  Id   Target Id                                           Frame \n"
      ~"* 1    Thread 0x7ffff7c30740 (LWP 19302) \"user-selected-c\" main () at
/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c:60\n"
      ~"  2    Thread 0x7ffff7c2f700 (LWP 19306) \"user-selected-c\"
child_sub_function () at
/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c:30\n"
      ~"  3    Thread 0x7ffff742e700 (LWP 19307) \"user-selected-c\"
child_sub_function () at
/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c:30\n"
      ^done
      (gdb)
      info frame
      &"info frame\n"
      ~"Stack level 0, frame at 0x7fffffffdf90:\n"
      ~" rip = 0x555555555207 in main
(/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c:60); saved rip
= 0x7ffff7c5709b\n"
      ~" source language c.\n"
      ~" Arglist at 0x7fffffffdf80, args: \n"
      ~" Locals at 0x7fffffffdf80, Previous frame's sp is 0x7fffffffdf90\n"
      ~" Saved registers:\n "
      ~" rbp at 0x7fffffffdf80, rip at 0x7fffffffdf88\n"
      ^done
      (gdb)
      -stack-info-depth --thread 3
      ^done,depth="4"
      (gdb)
      info thread
      &"info thread\n"
      ~"  Id   Target Id                                           Frame \n"
      ~"  1    Thread 0x7ffff7c30740 (LWP 19302) \"user-selected-c\" main () at
/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c:60\n"
      ~"  2    Thread 0x7ffff7c2f700 (LWP 19306) \"user-selected-c\"
child_sub_function () at
/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c:30\n"
      ~"* 3    Thread 0x7ffff742e700 (LWP 19307) \"user-selected-c\"
child_sub_function () at
/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c:30\n"
      ^done
      (gdb)
      info frame
      &"info frame\n"
      ~"Stack level 0, frame at 0x7ffff742dee0:\n"
      ~" rip = 0x555555555169 in child_sub_function
(/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c:30); saved rip
= 0x555555555188\n"
      ~" called by frame at 0x7ffff742df00\n"
      ~" source language c.\n"
      ~" Arglist at 0x7ffff742ded0, args: \n"
      ~" Locals at 0x7ffff742ded0, Previous frame's sp is 0x7ffff742dee0\n"
      ~" Saved registers:\n "
      ~" rbp at 0x7ffff742ded0, rip at 0x7ffff742ded8\n"
      ^done
      (gdb)

    This caused problems for frontends that provide access to CLI because UI
    may silently change the context for CLI commands (as demonstrated above).

    This commit fixes the problem by restoring thread and frame in
    mi_cmd_execute (). With this change, there are only two GDB/MI commands
    that can change user selected context: -thread-select and
-stack-select-frame.
    This allows us to remove all and rather complicated logic of notifying
    about user selected context change from mi_execute_command (), leaving it
    to these two commands themselves to notify.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=20684

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug mi/20684] MI commands with "--thread X" cause a switch of the user-selected thread

[eliz at gnu dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20684

Eli Zaretskii <eliz at gnu dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eliz at gnu dot org

--- Comment #2 from Eli Zaretskii <eliz at gnu dot org> ---
Created attachment 14038
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14038&action=edit
More thorough patch to fix the gdb-mi problem as well

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug mi/20684] MI commands with "--thread X" cause a switch of the user-selected thread

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20684

--- Comment #3 from Hannes Domani <ssbssa at sourceware dot org> ---
*** Bug 19087 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug mi/20684] MI commands with "--thread X" cause a switch of the user-selected thread

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20684

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.1
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |ssbssa at sourceware dot org

--- Comment #4 from Hannes Domani <ssbssa at sourceware dot org> ---
(In reply to Sourceware Commits from comment #1)
> The master branch has been updated by Andrew Burgess
> <aburgess@sourceware.org>:
> 
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;
> h=a9c82bc13cf8dd5d9076e746f744ee711eb55507
> 
> commit a9c82bc13cf8dd5d9076e746f744ee711eb55507
> Author: Jan Vrany <jan.vrany@labware.com>
> Date:   Wed Mar 2 13:23:30 2022 +0000
> 
>     gdb/mi: preserve user selected thread and frame when invoking MI commands
>     
>     Fix for PR gdb/20684.  When invoking MI commands with --thread and/or
>     --frame, the user selected thread and frame was not preserved:

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.