[Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+

[Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22790

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|arm simu:                   |arm sim:
                   |Handle_Store_Double()       |Handle_Store_Double()
                   |requires too strict         |requires too strict
                   |alignment                   |alignment for v6+
           Assignee|unassigned at sourceware dot org   |nickc at redhat dot com

--- Comment #1 from Mike Frysinger <vapier at gentoo dot org> ---
looks like Handle_Load_Double does:
  if (state->is_v6 && (addr & 0x3) == 0)
    /* Word alignment is enough for v6.  */
    ; 
  /* The address must be aligned on a 8 byte boundary.  */
  else if (addr & 0x7)

i guess we should copy that logic over to Handle_Store_Double ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22790

--- Comment #2 from Nick Clifton <nickc at redhat dot com> ---
Created attachment 13399
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13399&action=edit
Proposed patch

Agreed.

Aldy - does this patch solve the problem for you ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22790

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+

[aldyh at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22790

--- Comment #3 from aldyh at redhat dot com ---
On 4/26/21 4:37 PM, nickc at redhat dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=22790
> 
> --- Comment #2 from Nick Clifton <nickc at redhat dot com> ---
> Created attachment 13399
>    --> https://sourceware.org/bugzilla/attachment.cgi?id=13399&action=edit
> Proposed patch
> 
> Agreed.
> 
> Aldy - does this patch solve the problem for you ?

I don't really have state on this.  I ran into this while fixing an 
unknown PR for GCC years ago, and wouldn't know how to reproduce even if 
I tried though.

But it seems like the correct fix :).

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22790

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nick Clifton <nickc@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f6b9562fd912cc507ef4eb8be9ccb9f132810758

commit f6b9562fd912cc507ef4eb8be9ccb9f132810758
Author: Nick Clifton <nickc@redhat.com>
Date:   Mon Apr 26 17:16:20 2021 +0100

    Fix a bug in the ARM emulator which would not allow 4 byte alignment for
double word stores.

            PR 22790
            * armemu.c (Handle_Store_Double): Allow 4 byte alignment when
            running in v6 mode.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22790

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |NOTABUG

--- Comment #5 from Nick Clifton <nickc at redhat dot com> ---
Alright, patch applied.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22790

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOTABUG                     |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.