[Bug gdb/23555] Segmentation fault on attempt to print warning that getcwd failed

[Bug gdb/23555] Segmentation fault on attempt to print warning that getcwd failed

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23555

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ssbssa at sourceware dot org

--- Comment #7 from Hannes Domani <ssbssa at sourceware dot org> ---
(In reply to Sourceware Commits from comment #5)
> The master branch has been updated by Tom Tromey <tromey@sourceware.org>:
> 
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;
> h=20f0d60db4fb5083779c4c9182bbc692f7d2bac5
> 
> commit 20f0d60db4fb5083779c4c9182bbc692f7d2bac5
> Author: Tom Tromey <tom@tromey.com>
> Date:   Fri Oct 5 14:54:35 2018 -0600
> 
>     Avoid crash when calling warning too early
>     
>     I noticed that if you pass the name of an existing file (not a
>     directory) as the argument to --data-directory, gdb will crash:
>     
>         $ ./gdb -nx  --data-directory  ./gdb
>         ../../binutils-gdb/gdb/target.c:590:56: runtime error: member call
> on null pointer of type 'struct target_ops'
>     
>     This was later reported as PR gdb/23838.
>     
>     This happens because warning ends up calling
>     target_supports_terminal_ours, which calls current_top_target, which
>     returns nullptr this early.
>     
>     This fixes the problem by handling this case specially in
>     target_supports_terminal_ours.  I also changed
>     target_supports_terminal_ours to return bool.
>     
>     gdb/ChangeLog
>     2018-11-08  Tom Tromey  <tom@tromey.com>
>     
>     	PR gdb/23555:
>     	PR gdb/23838:
>     	* target.h (target_supports_terminal_ours): Return bool.
>     	* target.c (target_supports_terminal_ours): Handle case where
>     	current_top_target returns nullptr.  Return bool.
>     
>     gdb/testsuite/ChangeLog
>     2018-11-08  Tom Tromey  <tom@tromey.com>
>     
>     	PR gdb/23555:
>     	PR gdb/23838:
>     	* gdb.base/warning.exp: New file.

Can this be closed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.