[Bug gdb/24549] [cc-with-gdb-index/cc-with-debug-names] DW_AT_main_subprogram ignored

[Bug gdb/24549] [cc-with-gdb-index/cc-with-debug-names] DW_AT_main_subprogram ignored

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24549

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|DW_AT_main_subprogram       |[cc-with-gdb-index/cc-with-
                   |ignored with                |debug-names]
                   |cc-with-gdb-index/cc-with-d |DW_AT_main_subprogram
                   |ebug-names                  |ignored

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/24549] [cc-with-gdb-index/cc-with-debug-names] DW_AT_main_subprogram ignored

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24549

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdb                         |symtab

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/24549] [cc-with-gdb-index/cc-with-debug-names] DW_AT_main_subprogram ignored

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24549

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a22ec6e8a4b9006e342ad20c36357a5ba8ba1e74

commit a22ec6e8a4b9006e342ad20c36357a5ba8ba1e74
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Feb 5 10:56:39 2021 +0100

    [gdb/testsuite] Add KFAILs for PR symtab/24549

    When an executable contains an index such as a .gdb_index or .debug_names
    section, gdb ignores the DW_AT_subprogram attribute.

    This problem has been filed as PR symtab/24549.

    Add KFAILs for this PR in test-cases gdb.dwarf2/main-subprogram.exp and
    gdb.fortran/mixed-lang-stack.exp.

    Tested on x86_64-linux.

    gdb/testsuite/ChangeLog:

    2021-02-05  Tom de Vries  <tdevries@suse.de>

            * gdb.dwarf2/main-subprogram.exp: Add KFAIL for PR symtab/24549.
            * gdb.fortran/mixed-lang-stack.exp: Same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/24549] [cc-with-gdb-index/cc-with-debug-names] DW_AT_main_subprogram ignored

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24549

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Filed RFC to fix this in .debug_names:
https://sourceware.org/pipermail/gdb-patches/2021-February/175862.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/24549] [cc-with-gdb-index/cc-with-debug-names] DW_AT_main_subprogram ignored

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24549

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
See also bug #13795.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/24549] [cc-with-gdb-index/cc-with-debug-names] DW_AT_main_subprogram ignored

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24549

--- Comment #7 from Tom Tromey <tromey at sourceware dot org> ---
I think this is the current leading idea for a fix:

https://sourceware.org/pipermail/gdb-patches/2021-March/176709.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/24549] [cc-with-gdb-index/cc-with-debug-names] DW_AT_main_subprogram ignored

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24549

--- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> ---
gdb-index solution:
https://sourceware.org/pipermail/gdb-patches/2023-August/201568.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/24549] [cc-with-gdb-index/cc-with-debug-names] DW_AT_main_subprogram ignored

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24549

--- Comment #9 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8b9c08eddac038663b8f5ede4b4d24e441a6d8a3

commit 8b9c08eddac038663b8f5ede4b4d24e441a6d8a3
Author: Matheus Branco Borella <dark.ryu.550@gmail.com>
Date:   Tue Oct 10 10:26:40 2023 +0200

    [gdb/symtab] Add name_of_main and language_of_main to the DWARF index

    This patch adds a new section to the DWARF index containing the name
    and the language of the main function symbol, gathered from
    `cooked_index::get_main`, if available. Currently, for lack of a better
name,
    this section is called the "shortcut table". The way this name is both
saved and
    applied upon an index being loaded in mirrors how it is done in
    `cooked_index_functions`, more specifically, the full name of the main
function
    symbol is saved and `set_objfile_main_name` is used to apply it after it is
    loaded.

    The main use case for this patch is in improving startup times when dealing
with
    large binaries. Currently, when an index is used, GDB has to expand symtabs
    until it finds out what the language of the main function symbol is. For
some
    large executables, this may take a considerable amount of time to complete,
    slowing down startup. This patch bypasses that operation by having both the
name
    and language of the main function symbol be provided ahead of time by the
index.

    In my testing (a binary with about 1.8GB worth of DWARF data) this change
brings
    startup time down from about 34 seconds to about 1.5 seconds.

    When testing the patch with target board cc-with-gdb-index, test-case
    gdb.fortran/nested-funcs-2.exp starts failing, but this is due to a
    pre-existing issue, filed as PR symtab/30946.

    Tested on x86_64-linux, with target board unix and cc-with-gdb-index.

    PR symtab/24549
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24549

    Approved-By: Tom de Vries <tdevries@suse.de>

-- 
You are receiving this mail because:
You are on the CC list for the bug.