[Bug ada/24713] [ada] Support .gdb_index

[Bug ada/24713] [ada] Support .gdb_index

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24713

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[ada] Support index         |[ada] Support .gdb_index
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #2)
> FWIW gdb can make a .debug_names index now for Ada.
> It still can't create a .gdb_index -- but I tend to think
> we should just declare that one a "won't fix".

Because, as that commit says:
...
commit 3b00ef10a2a4750a86a04bb66eda3bf33d298be1
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Jul 8 06:23:16 2019 -0600

    Add Ada support for .debug_names

    This patch adds support for Ada to .debug_names.  I opted to leave
    .gdb_index alone, because in my view it is a defunct format.
...


Changing title to restrict PR scope to .gdb_index, and marking it
resolved-wontfix.

If somebody want to add this functionality, this PR can always be reopened.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/24713] [ada] Support .gdb_index

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24713

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |---
             Status|RESOLVED                    |REOPENED

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
> If somebody want to add this functionality, this PR can always be reopened.

Preparing a patch, reopening.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/24713] [ada] Support .gdb_index

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24713

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #4)
> > If somebody want to add this functionality, this PR can always be reopened.
> 
> Preparing a patch, reopening.

https://sourceware.org/pipermail/gdb-patches/2020-June/169215.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/24713] [ada] Support .gdb_index

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24713

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ab967941150b2f79fc089893bf51e6bb53d245b

commit 7ab967941150b2f79fc089893bf51e6bb53d245b
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Jun 10 14:46:53 2020 +0200

    [gdb/symtab] Enable ada .gdb_index

    Currently the .gdb_index is not enabled for ada executables (PR24713).

    Fix this by adding the required support in write_psymbols, similar to how
that
    is done for .debug_names in debug_names::insert.

    Tested on x86_64-linux, with native and target board cc-with-gdb-index.

    gdb/ChangeLog:

    2020-06-10  Tom de Vries  <tdevries@suse.de>

            PR ada/24713
            * dwarf2/index-write.c (struct mapped_symtab): Add
m_string_obstack.
            (write_psymbols): Enable .gdb_index for ada.
            * dwarf2/read.c: Remove comment stating .gdb_index is unsupported
for
            ada.

    gdb/testsuite/ChangeLog:

    2020-06-10  Tom de Vries  <tdevries@suse.de>

            * gdb.ada/ptype_union.exp: Remove PR24713 workaround.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/24713] [ada] Support .gdb_index

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24713

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch enabling .gdb_index for ada committed, marking resolved-fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.