* [Bug build/24835] powerpc build breaker with Werror=odr
[not found] <bug-24835-4717@http.sourceware.org/bugzilla/>
@ 2022-02-27 23:07 ` tromey at sourceware dot org
2022-07-30 1:27 ` keiths at redhat dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2022-02-27 23:07 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=24835
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org
--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Is it enough to just remove that 'const' from regdat.sh?
That seems like an unobjectionable patch to me.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug build/24835] powerpc build breaker with Werror=odr
[not found] <bug-24835-4717@http.sourceware.org/bugzilla/>
2022-02-27 23:07 ` [Bug build/24835] powerpc build breaker with Werror=odr tromey at sourceware dot org
@ 2022-07-30 1:27 ` keiths at redhat dot com
2022-09-09 0:56 ` tromey at sourceware dot org
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: keiths at redhat dot com @ 2022-07-30 1:27 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=24835
Keith Seitz <keiths at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |keiths at redhat dot com
--- Comment #2 from Keith Seitz <keiths at redhat dot com> ---
(In reply to Tom Tromey from comment #1)
> Is it enough to just remove that 'const' from regdat.sh?
> That seems like an unobjectionable patch to me.
It is enough to get PowerPC building again. The question is,
would we rather change everything to 'const' instead? While
noticeably less trivial, it does work. [Tested on x86_64,
aarch64, ppc64le, s390x rawhide scratch-builds enabling LTO.]
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug build/24835] powerpc build breaker with Werror=odr
[not found] <bug-24835-4717@http.sourceware.org/bugzilla/>
2022-02-27 23:07 ` [Bug build/24835] powerpc build breaker with Werror=odr tromey at sourceware dot org
2022-07-30 1:27 ` keiths at redhat dot com
@ 2022-09-09 0:56 ` tromey at sourceware dot org
2022-09-09 0:56 ` tromey at sourceware dot org
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2022-09-09 0:56 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=24835
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |22395
--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
See also the generic ODR bug.
I don't recall what other violations I knew about when
I commented there, but I assume I just did a build with
LTO and -Wodr.
Referenced Bugs:
https://sourceware.org/bugzilla/show_bug.cgi?id=22395
[Bug 22395] ODR violations
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug build/24835] powerpc build breaker with Werror=odr
[not found] <bug-24835-4717@http.sourceware.org/bugzilla/>
` (2 preceding siblings ...)
2022-09-09 0:56 ` tromey at sourceware dot org
@ 2022-09-09 0:56 ` tromey at sourceware dot org
2022-11-10 22:09 ` tromey at sourceware dot org
2022-11-11 5:31 ` sam at gentoo dot org
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2022-09-09 0:56 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=24835
--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Keith Seitz from comment #2)
> (In reply to Tom Tromey from comment #1)
> > Is it enough to just remove that 'const' from regdat.sh?
> > That seems like an unobjectionable patch to me.
>
> It is enough to get PowerPC building again. The question is,
> would we rather change everything to 'const' instead?
If they are truly unchanging then it definitely seems better.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug build/24835] powerpc build breaker with Werror=odr
[not found] <bug-24835-4717@http.sourceware.org/bugzilla/>
` (3 preceding siblings ...)
2022-09-09 0:56 ` tromey at sourceware dot org
@ 2022-11-10 22:09 ` tromey at sourceware dot org
2022-11-11 5:31 ` sam at gentoo dot org
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2022-11-10 22:09 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=24835
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Target Milestone|--- |13.1
Status|NEW |RESOLVED
--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
I think this was fixed by
commit ac9b8c676e9f52c5238bbc61a2cdd27e3d59db10
Author: Keith Seitz <keiths@redhat.com>
Date: Fri Sep 9 08:44:50 2022 -0700
Constify target_desc declarations
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug build/24835] powerpc build breaker with Werror=odr
[not found] <bug-24835-4717@http.sourceware.org/bugzilla/>
` (4 preceding siblings ...)
2022-11-10 22:09 ` tromey at sourceware dot org
@ 2022-11-11 5:31 ` sam at gentoo dot org
5 siblings, 0 replies; 6+ messages in thread
From: sam at gentoo dot org @ 2022-11-11 5:31 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=24835
Sam James <sam at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sam at gentoo dot org
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread