public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32)
[not found] <bug-25025-4717@http.sourceware.org/bugzilla/>
@ 2020-03-20 16:16 ` tromey at sourceware dot org
2020-03-20 17:29 ` tromey at sourceware dot org
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-03-20 16:16 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25025
--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
One weird thing I see is that the linkage names all demangle
to the same thing:
murgatroyd. nm ./outputs/gdb.rust/generics/generics |grep ident
000000000001a8d0 t _ZN14rustc_demangle2v06Parser5ident17hd246e8f232202204E
0000000000004e00 t _ZN8generics8identity17h0c3a5bc2a2b8859fE
0000000000004e10 t _ZN8generics8identity17h0fa0c53502fafa11E
0000000000004e20 t _ZN8generics8identity17h12f1c22e0bab1915E
0000000000004e30 t _ZN8generics8identity17h6555574b96ab1837E
murgatroyd. nm -C ./outputs/gdb.rust/generics/generics |grep ident
000000000001a8d0 t rustc_demangle::v0::Parser::ident
0000000000004e00 t generics::identity
0000000000004e10 t generics::identity
0000000000004e20 t generics::identity
0000000000004e30 t generics::identity
This shouldn't be the problem though.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32)
[not found] <bug-25025-4717@http.sourceware.org/bugzilla/>
2020-03-20 16:16 ` [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32) tromey at sourceware dot org
@ 2020-03-20 17:29 ` tromey at sourceware dot org
2020-03-24 15:35 ` tromey at sourceware dot org
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-03-20 17:29 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25025
--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
The partial symtab has the symbol:
Partial symtab for source file
/home/tromey/gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.rust/generics.rs
(object 0x3f3abc0)
[...]
`generics::identity<u32>', function, 0x4e20
However it is given a different name in the full symtab:
block #000, object at 0x2c676b0, 1 syms/buckets in
0x555555558e00..0x555555558ebc
block #001, object at 0x2c67580 under 0x2c676b0, 3 syms/buckets in
0x555555558e00..0x555555558ebc
[...]
fn generics::identity(u32) -> u32; block object 0x2c5e400,
0x555555558e20..0x555555558e2f section .text
gdb's terrible symbol tables strike again.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32)
[not found] <bug-25025-4717@http.sourceware.org/bugzilla/>
2020-03-20 16:16 ` [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32) tromey at sourceware dot org
2020-03-20 17:29 ` tromey at sourceware dot org
@ 2020-03-24 15:35 ` tromey at sourceware dot org
2020-04-24 13:10 ` vries at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-03-24 15:35 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25025
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |tromey at sourceware dot org
--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
I have a fix.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32)
[not found] <bug-25025-4717@http.sourceware.org/bugzilla/>
` (2 preceding siblings ...)
2020-03-24 15:35 ` tromey at sourceware dot org
@ 2020-04-24 13:10 ` vries at gcc dot gnu.org
2020-04-24 21:36 ` cvs-commit at gcc dot gnu.org
2020-04-24 21:36 ` tromey at sourceware dot org
5 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2020-04-24 13:10 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25025
--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #5)
> I have a fix.
https://sourceware.org/pipermail/gdb-patches/2020-March/166993.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32)
[not found] <bug-25025-4717@http.sourceware.org/bugzilla/>
` (3 preceding siblings ...)
2020-04-24 13:10 ` vries at gcc dot gnu.org
@ 2020-04-24 21:36 ` cvs-commit at gcc dot gnu.org
2020-04-24 21:36 ` tromey at sourceware dot org
5 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-04-24 21:36 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25025
--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=906bb4c58faa8e2c1c62e295f8054e75e910e5e8
commit 906bb4c58faa8e2c1c62e295f8054e75e910e5e8
Author: Tom Tromey <tom@tromey.com>
Date: Fri Apr 24 15:35:01 2020 -0600
Fix Rust test cases
PR rust/25025 notes that some Rust test cases fail.
Debugging gdb revealed that the Rust compiler emits different linkage
names that demangle to the same result. Enabling complaints when
reading the test case is enough to show it:
During symbol reading: Computed physname <generics::identity<f64>> does
not match demangled <generics::identity> (from linkage
<_ZN8generics8identity17h8540b320af6656d6E>) - DIE at 0x424 [in module
/home/tromey/gdb/build/gdb/testsuite/outputs/gdb.rust/generics/generics]
During symbol reading: Computed physname <generics::identity<u32>> does
not match demangled <generics::identity> (from linkage
<_ZN8generics8identity17hae302fad0c33bd7dE>) - DIE at 0x459 [in module
/home/tromey/gdb/build/gdb/testsuite/outputs/gdb.rust/generics/generics]
...
This patch changes the DWARF reader to prefer the computed physname,
rather than the output of the demangler, for Rust. This fixes the
bug.
gdb/ChangeLog
2020-04-24 Tom Tromey <tom@tromey.com>
PR rust/25025:
* dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32)
[not found] <bug-25025-4717@http.sourceware.org/bugzilla/>
` (4 preceding siblings ...)
2020-04-24 21:36 ` cvs-commit at gcc dot gnu.org
@ 2020-04-24 21:36 ` tromey at sourceware dot org
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-04-24 21:36 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25025
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Target Milestone|--- |10.1
Resolution|--- |FIXED
--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-24 21:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-25025-4717@http.sourceware.org/bugzilla/>
2020-03-20 16:16 ` [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32) tromey at sourceware dot org
2020-03-20 17:29 ` tromey at sourceware dot org
2020-03-24 15:35 ` tromey at sourceware dot org
2020-04-24 13:10 ` vries at gcc dot gnu.org
2020-04-24 21:36 ` cvs-commit at gcc dot gnu.org
2020-04-24 21:36 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).