[Bug remote/25111] [Zephyr/thread aware debugging] remote: write_ptid returns negative tid.

["tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=25111

--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
I looked a little.

Changing ptid_t::pid_type to be unsigned is probably a colossal
change, bordering on the impossible.

However, it does seem that negative values aren't really intended --
except for the special case of -1.  The manual says:

The PID (process) and TID
(thread) components each have the format described above: a positive
number with target-specific interpretation formatted as a big-endian hex
string, literal ‘-1’ to indicate all processes or threads
(respectively), or ‘0’ to indicate an arbitrary process or thread.

So in remote_target::write_ptid, I wonder if it's sufficient to
change the "pid < 0" check to "pid == -1" (and likewise for tid).

-- 
You are receiving this mail because:
You are on the CC list for the bug.