[Bug remote/25111] [Zephyr/thread aware debugging] remote: write_ptid returns negative tid.

["fredrik.hederstierna@securitas-direct.com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=25111

Fredrik Hederstierna <fredrik.hederstierna@securitas-direct.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fredrik.hederstierna@securi
                   |                            |tas-direct.com

--- Comment #1 from Fredrik Hederstierna <fredrik.hederstierna@securitas-direct.com> ---
When looking into Zephyr and OpenOCD I just saw this ticket. Isn't there a
discrepancy in <gdb/remote.c> for ptid_t write/read when it comes to types. The
'lwp' is used as 'tid', but has a wider type:

  int   ptid_get_pid (ptid_t ptid)
  long  ptid_get_lwp (ptid_t ptid)
  long  ptid_get_tid (ptid_t ptid)

so in the <read_ptid> it reads into ULONGEST, which I guess is uint64_t, but
the <write_tpid> instead implicit cast long to int when using 'lwp as 'tid'
(which I believe is often int32_t on a normal host target machine):

  int tid;
  tid = ptid.lwp ();

Wouldn't it be better to keep the wider long type, and keep calling 'tid' for
'lwp' which it actually is? And also keeping the long-type in the write
function? In this case there won't be any overflow if an 32bit int representing
'tid' is becoming >0x80000000. The read function I guess will still handle it
as it is using ULONGEST to my understanding.

Attaching idea of a possible patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.