[Bug python/25261] [cc-with-dwz-m] FAIL: gdb.python/py-symbol.exp: print (len (gdb.lookup_static_symbols ('rr')))

[Bug python/25261] [cc-with-dwz-m] FAIL: gdb.python/py-symbol.exp: print (len (gdb.lookup_static_symbols ('rr')))

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25261

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/gdb-patches/2023-August/201905.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25261] [cc-with-dwz-m] FAIL: gdb.python/py-symbol.exp: print (len (gdb.lookup_static_symbols ('rr')))

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25261

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|python                      |symtab

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25261] [cc-with-dwz-m] FAIL: gdb.python/py-symbol.exp: print (len (gdb.lookup_static_symbols ('rr')))

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25261

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e061219f5d600af5b33418553f192e0cb9fc9ca9

commit e061219f5d600af5b33418553f192e0cb9fc9ca9
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Sep 6 11:00:01 2023 +0200

    [gdb/symtab] Fix too many symbols in gdbpy_lookup_static_symbols

    When running test-case gdb.python/py-symbol.exp with target board
    cc-with-dwz-m, we run into:
    ...
    (gdb) python print (len (gdb.lookup_static_symbols ('rr')))^M
    4^M
    (gdb) FAIL: gdb.python/py-symbol.exp: \
      print (len (gdb.lookup_static_symbols ('rr')))
    ...
    while with target board unix we have instead:
    ...
    (gdb) python print (len (gdb.lookup_static_symbols ('rr')))^M
    2^M
    (gdb) PASS: gdb.python/py-symbol.exp: \
      print (len (gdb.lookup_static_symbols ('rr')))
    ...

    The problem is that the loop in gdbpy_lookup_static_symbols loops over
compunits
    representing both CUs and PUs:
    ...
              for (compunit_symtab *cust : objfile->compunits ())
    ...

    When doing a lookup on a PU, the user link is followed until we end up at a
CU,
    and the lookup is done in that CU.

    In other words, when doing a lookup in the loop for a PU we duplicate the
    lookup for a CU that is already handled by the loop.

    Fix this by skipping PUs in the loop in gdb.lookup_static_symbols.

    Tested on x86_64-linux.

    PR symtab/25261
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=25261

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25261] [cc-with-dwz-m] FAIL: gdb.python/py-symbol.exp: print (len (gdb.lookup_static_symbols ('rr')))

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25261

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |14.1

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.