public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug tui/25348] Segfault on mode switch from TUI to CLI
[not found] <bug-25348-4717@http.sourceware.org/bugzilla/>
@ 2020-06-06 18:18 ` tromey at sourceware dot org
2020-06-06 18:49 ` tromey at sourceware dot org
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-06-06 18:18 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25348
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |phi.debian at gmail dot com
--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
*** Bug 26036 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tui/25348] Segfault on mode switch from TUI to CLI
[not found] <bug-25348-4717@http.sourceware.org/bugzilla/>
2020-06-06 18:18 ` [Bug tui/25348] Segfault on mode switch from TUI to CLI tromey at sourceware dot org
@ 2020-06-06 18:49 ` tromey at sourceware dot org
2020-06-06 20:07 ` tromey at sourceware dot org
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-06-06 18:49 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25348
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nliber+sourceware at gmail dot com
--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
*** Bug 26049 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tui/25348] Segfault on mode switch from TUI to CLI
[not found] <bug-25348-4717@http.sourceware.org/bugzilla/>
2020-06-06 18:18 ` [Bug tui/25348] Segfault on mode switch from TUI to CLI tromey at sourceware dot org
2020-06-06 18:49 ` tromey at sourceware dot org
@ 2020-06-06 20:07 ` tromey at sourceware dot org
2020-06-17 0:03 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-06-06 20:07 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25348
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |tromey at sourceware dot org
CC| |tromey at sourceware dot org
--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
I have a patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tui/25348] Segfault on mode switch from TUI to CLI
[not found] <bug-25348-4717@http.sourceware.org/bugzilla/>
` (2 preceding siblings ...)
2020-06-06 20:07 ` tromey at sourceware dot org
@ 2020-06-17 0:03 ` cvs-commit at gcc dot gnu.org
2020-06-17 12:22 ` tromey at sourceware dot org
2020-09-04 11:58 ` tromey at sourceware dot org
5 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-06-17 0:03 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25348
--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a350efd4fb368a35ada608f6bc26ccd3bed0ae6b
commit a350efd4fb368a35ada608f6bc26ccd3bed0ae6b
Author: Tom Tromey <tom@tromey.com>
Date: Tue Jun 16 17:55:57 2020 -0600
Fix crash when exiting TUI with gdb -tui
PR tui/25348 points out that, when "gdb -tui" is used, then exiting
the TUI will cause a crash.
This happens because tui_setup_io stashes some readline variables --
but because this happens before readline is initialized, some of these
are NULL. Then, when exiting the TUI, the NULL values are "restored",
causing a crash in readline.
This patch fixes the problem by ensuring that readline is initialized
first. Back in commit 11061048d ("Give a name to the TUI SingleKey
keymap"), a call to rl_initialize was removed from
tui_initialize_readline; this patch resurrects the call, but moves it
to the end of the function, so as not to remove the ability to modify
the SingleKey map from .inputrc.
gdb/ChangeLog
2020-06-16 Tom Tromey <tom@tromey.com>
PR tui/25348:
* tui/tui.c (tui_ensure_readline_initialized): Rename from
tui_initialize_readline. Only run once. Call rl_initialize.
* tui/tui.h (tui_ensure_readline_initialized): Rename from
tui_initialize_readline.
* tui/tui-io.c (tui_setup_io): Call
tui_ensure_readline_initialized.
* tui/tui-interp.c (tui_interp::init): Update.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tui/25348] Segfault on mode switch from TUI to CLI
[not found] <bug-25348-4717@http.sourceware.org/bugzilla/>
` (3 preceding siblings ...)
2020-06-17 0:03 ` cvs-commit at gcc dot gnu.org
@ 2020-06-17 12:22 ` tromey at sourceware dot org
2020-09-04 11:58 ` tromey at sourceware dot org
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-06-17 12:22 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25348
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Target Milestone|--- |10.1
Resolution|--- |FIXED
--- Comment #7 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tui/25348] Segfault on mode switch from TUI to CLI
[not found] <bug-25348-4717@http.sourceware.org/bugzilla/>
` (4 preceding siblings ...)
2020-06-17 12:22 ` tromey at sourceware dot org
@ 2020-09-04 11:58 ` tromey at sourceware dot org
5 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-09-04 11:58 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=25348
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nonya_bizzness at yahoo dot com
--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
*** Bug 26572 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-04 11:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-25348-4717@http.sourceware.org/bugzilla/>
2020-06-06 18:18 ` [Bug tui/25348] Segfault on mode switch from TUI to CLI tromey at sourceware dot org
2020-06-06 18:49 ` tromey at sourceware dot org
2020-06-06 20:07 ` tromey at sourceware dot org
2020-06-17 0:03 ` cvs-commit at gcc dot gnu.org
2020-06-17 12:22 ` tromey at sourceware dot org
2020-09-04 11:58 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).