[Bug tui/25597] Missing ncurses.h causes miscompilation of python/py-tui.c

[Bug tui/25597] Missing ncurses.h causes miscompilation of python/py-tui.c

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25597

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Simon got to the bottom of this one here:

https://sourceware.org/pipermail/gdb-patches/2020-March/166519.html

I think your proposed patch is actually fine, given that
explanation.  It probably needs a comment though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/25597] Missing ncurses.h causes miscompilation of python/py-tui.c

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25597

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-03-31
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/25597] Missing ncurses.h causes miscompilation of python/py-tui.c

[simark at simark dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=25597

Simon Marchi <simark at simark dot ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simark at simark dot ca

--- Comment #2 from Simon Marchi <simark at simark dot ca> ---
For reference, here's a Python bug about this problem (Python.h includes
pyconfig.h, which exposes configure macros with common names):

https://bugs.python.org/issue20768

I wouldn't count on it being fixed though.  The patch looks fine to me as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/25597] Missing ncurses.h causes miscompilation of python/py-tui.c

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25597

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6f29a53415003fd958978471801c072b2fcc8f80

commit 6f29a53415003fd958978471801c072b2fcc8f80
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Mar 31 14:07:04 2020 -0600

    Fix py-tui.c build problem

    py-tui.c can fail to build if the ncurses development headers are not
    installed, but if Python was built against ncurses.  In this case, the
    Python headers will define HAVE_NCURSES_H, confusing gdb_curses.h.

    This patch fixes the problem by moving this include inside
    "#ifdef TUI".

    gdb/ChangeLog
    2020-03-31  Joel Jones  <joelkevinjones@gmail.com>

            PR tui/25597:
            * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/25597] Missing ncurses.h causes miscompilation of python/py-tui.c

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25597

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |10.1

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Thanks for the patch.  I've checked it in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.