[Bug gdb/25649] New: [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[Bug gdb/25649] New: [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

            Bug ID: 25649
           Summary: [AArch64] Regressions on gdb.opt/inline-break.exp
                    gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp
                    gdb.reverse/insn-reverse.exp
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: luis.machado at linaro dot org
  Target Milestone: ---

Filing it so we can track it properly.

Commit 1009d92fc621bc4d017029b90a5bfab16e17fde5 seems to have caused several
regressions in GDB's testsuite, leading to a number of internal errors when
trying to process frames.

The following testcases are affected:

gdb.opt/inline-break.exp
gdb.opt/inline-cmds.exp
gdb.python/py-frame-inline.exp
gdb.reverse/insn-reverse.exp

I see the following:

info frame^M
../../../repos/binutils-gdb/gdb/frame.c:579: internal-error: frame_id
get_frame_id(frame_info*): Assertion `fi->level == 0' failed.^M
A problem internal to GDB has been detected,^M
further debugging may prove unreliable.^M
Quit this debugging session? (y or n) FAIL: gdb.python/py-frame-inline.exp:
info frame (GDB internal error)
Resyncing due to internal error.
n^M
^M
This is a bug, please report it.  For instructions, see:^M
<http://www.gnu.org/software/gdb/bugs/>.^M


(gdb) up^M
../../../repos/binutils-gdb/gdb/inline-frame.c:172: internal-error: void
inline_frame_this_id(frame_info*, void**, frame_id*): Assertion `frame_id_p
(*this_id)' failed.^M
A problem internal to GDB has been detected,^M
further debugging may prove unreliable.^M
Quit this debugging session? (y or n) FAIL: gdb.python/py-frame-inline.exp: up
(GDB internal error)
Resyncing due to internal error.
n^M
^M
This is a bug, please report it.  For instructions, see:^M
<http://www.gnu.org/software/gdb/bugs/>.^M

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luis.machado at linaro dot org
             Target|                            |aarch64-linux-gnu
           Priority|P2                          |P1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

--- Comment #1 from Luis Machado <luis.machado at linaro dot org> ---
Reproduction is easy...

"./gdb/gdb gdb/testsuite/outputs/gdb.opt/inline-break/inline-break  -ex "b
inline_func1" -ex "run"

If i move the dwarf2_tailcall_sniffer_first call out of dwarf2_frame_cache,
things work fine again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|aarch64-linux-gnu           |aarch64-linux-gnu,s390x-ibm
                   |                            |-linux-gnu

--- Comment #2 from Luis Machado <luis.machado at linaro dot org> ---
This is also a problem for s390, according to the buildbot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

--- Comment #3 from Luis Machado <luis.machado at linaro dot org> ---
>From what i've noticed, we're already in the middle of unwinding an inline
frame, but we end up trying to sniff for tailcall frames instead. That seems to
derail things.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

--- Comment #4 from Luis Machado <luis.machado at linaro dot org> ---
Also, the dwarf2_tailcall_sniffer_first attempts to fetch PC, which in turn
attempts to fetch LR, which is not available...

#0  0x0000ffffb77e2048 in __GI___poll (fds=0xaaaaab87bbb0,
nfds=187649988073568, timeout=<optimized out>) at
../sysdeps/unix/sysv/linux/poll.c:41
#1  0x0000aaaaaae1a884 in gdb_wait_for_event (block=1) at
../../../repos/binutils-gdb/gdb/event-loop.c:739
#2  0x0000aaaaaae19860 in gdb_do_one_event () at
../../../repos/binutils-gdb/gdb/event-loop.c:313
#3  0x0000aaaaab12b3e0 in gdb_readline_wrapper (
    prompt=0xaaaaab91e480 "../../../repos/binutils-gdb/gdb/frame.c:579:
internal-error: frame_id get_frame_id(frame_info*): Assertion `fi->level == 0'
failed.\nA problem internal to GDB has been detected,\nfurther debugging may
p"...) at ../../../repos/binutils-gdb/gdb/top.c:1105
#4  0x0000aaaaab1b0084 in defaulted_query (ctlstr=0xaaaaab427a48 "%s\nQuit this
debugging session? ", defchar=0 '\000', args=...)
    at ../../../repos/binutils-gdb/gdb/utils.c:867
#5  0x0000aaaaab1b04b8 in query (ctlstr=0xaaaaab427a48 "%s\nQuit this debugging
session? ") at ../../../repos/binutils-gdb/gdb/utils.c:959
#6  0x0000aaaaab1af068 in internal_vproblem (problem=0xaaaaab6defa0
<internal_error_problem>, file=0xaaaaab383f18
"../../../repos/binutils-gdb/gdb/frame.c",
    line=579, fmt=0xaaaaab383ee0 "%s: Assertion `%s' failed.", ap=...) at
../../../repos/binutils-gdb/gdb/utils.c:372
#7  0x0000aaaaab1af380 in internal_verror (file=0xaaaaab383f18
"../../../repos/binutils-gdb/gdb/frame.c", line=579,
    fmt=0xaaaaab383ee0 "%s: Assertion `%s' failed.", ap=...) at
../../../repos/binutils-gdb/gdb/utils.c:438
#8  0x0000aaaaab2dee70 in internal_error (file=0xaaaaab383f18
"../../../repos/binutils-gdb/gdb/frame.c", line=579,
    fmt=0xaaaaab383ee0 "%s: Assertion `%s' failed.") at
../../../repos/binutils-gdb/gdbsupport/errors.cc:55
#9  0x0000aaaaaae3aeec in get_frame_id (fi=0xaaaaab9fe840) at
../../../repos/binutils-gdb/gdb/frame.c:579
#10 0x0000aaaaaaeb1fb0 in inline_frame_this_id (this_frame=0xaaaaab9fe780,
this_cache=0xaaaaab9fe798, this_id=0xaaaaab9fe7e0)
    at ../../../repos/binutils-gdb/gdb/inline-frame.c:165
#11 0x0000aaaaaae3ad48 in compute_frame_id (fi=0xaaaaab9fe780) at
../../../repos/binutils-gdb/gdb/frame.c:550
#12 0x0000aaaaaae3aef4 in get_frame_id (fi=0xaaaaab9fe780) at
../../../repos/binutils-gdb/gdb/frame.c:582
#13 0x0000aaaaaae3605c in value_of_register_lazy (frame=0xaaaaab9fe840,
regnum=30) at ../../../repos/binutils-gdb/gdb/findvar.c:296
#14 0x0000aaaaaae397dc in frame_unwind_got_register (frame=0xaaaaab9fe840,
regnum=30, new_regnum=30) at ../../../repos/binutils-gdb/gdb/frame-unwind.c:268
#15 0x0000aaaaaad72b28 in dwarf2_frame_prev_register
(this_frame=0xaaaaab9fe840, this_cache=0xaaaaab9fe858, regnum=30)
    at ../../../repos/binutils-gdb/gdb/dwarf2/frame.c:1296
#16 0x0000aaaaaae3ca44 in frame_unwind_register_value
(next_frame=0xaaaaab9fe840, regnum=30) at
../../../repos/binutils-gdb/gdb/frame.c:1229
#17 0x0000aaaaaae3cee0 in frame_unwind_register_unsigned
(next_frame=0xaaaaab9fe840, regnum=30) at
../../../repos/binutils-gdb/gdb/frame.c:1320
#18 0x0000aaaaaab98298 in aarch64_dwarf2_prev_register
(this_frame=0xaaaaab9fe840, this_cache=0xaaaaab9fe858, regnum=32)
    at ../../../repos/binutils-gdb/gdb/aarch64-tdep.c:1114
#19 0x0000aaaaaad72c48 in dwarf2_frame_prev_register
(this_frame=0xaaaaab9fe840, this_cache=0xaaaaab9fe858, regnum=32)
    at ../../../repos/binutils-gdb/gdb/dwarf2/frame.c:1316
#20 0x0000aaaaaae3ca44 in frame_unwind_register_value
(next_frame=0xaaaaab9fe840, regnum=32) at
../../../repos/binutils-gdb/gdb/frame.c:1229
#21 0x0000aaaaaae3cee0 in frame_unwind_register_unsigned
(next_frame=0xaaaaab9fe840, regnum=32) at
../../../repos/binutils-gdb/gdb/frame.c:1320
#22 0x0000aaaaaae39660 in default_unwind_pc (gdbarch=0xaaaaab9d2110,
next_frame=0xaaaaab9fe840) at
../../../repos/binutils-gdb/gdb/frame-unwind.c:223
#23 0x0000aaaaaae53ca0 in gdbarch_unwind_pc (gdbarch=0xaaaaab9d2110,
next_frame=0xaaaaab9fe840) at ../../../repos/binutils-gdb/gdb/gdbarch.c:3074
#24 0x0000aaaaaad6f680 in dwarf2_tailcall_sniffer_first
(this_frame=0xaaaaab9fe840, tailcall_cachep=0xaaaaab9fe940,
entry_cfa_sp_offsetp=0x0)
    at ../../../repos/binutils-gdb/gdb/dwarf2/frame-tailcall.c:388
#25 0x0000aaaaaad725e4 in dwarf2_frame_cache (this_frame=0xaaaaab9fe840,
this_cache=0xaaaaab9fe858) at
../../../repos/binutils-gdb/gdb/dwarf2/frame.c:1190
#26 0x0000aaaaaad72728 in dwarf2_frame_this_id (this_frame=0xaaaaab9fe840,
this_cache=0xaaaaab9fe858, this_id=0xaaaaab9fe8a0)
    at ../../../repos/binutils-gdb/gdb/dwarf2/frame.c:1218
#27 0x0000aaaaaae3ad48 in compute_frame_id (fi=0xaaaaab9fe840) at
../../../repos/binutils-gdb/gdb/frame.c:550
#28 0x0000aaaaaae3e534 in get_prev_frame_if_no_cycle
(this_frame=0xaaaaab9fe780) at ../../../repos/binutils-gdb/gdb/frame.c:1927
#29 0x0000aaaaaae3e820 in get_prev_frame_always_1 (this_frame=0xaaaaab9fe780)
at ../../../repos/binutils-gdb/gdb/frame.c:2006
#30 0x0000aaaaaae3ec74 in get_prev_frame_always (this_frame=0xaaaaab9fe780) at
../../../repos/binutils-gdb/gdb/frame.c:2124
#31 0x0000aaaaaae3ab44 in skip_artificial_frames (frame=0xaaaaab9fe780) at
../../../repos/binutils-gdb/gdb/frame.c:495
#32 0x0000aaaaaae3afc4 in get_stack_frame_id (next_frame=0xaaaaab9fe780) at
../../../repos/binutils-gdb/gdb/frame.c:596
#33 0x0000aaaaaaea4288 in process_event_stop_test (ecs=0xffffffffefc8) at
../../../repos/binutils-gdb/gdb/infrun.c:6851
#34 0x0000aaaaaaea3410 in handle_signal_stop (ecs=0xffffffffefc8) at
../../../repos/binutils-gdb/gdb/infrun.c:6375
#35 0x0000aaaaaaea1804 in handle_inferior_event (ecs=0xffffffffefc8) at
../../../repos/binutils-gdb/gdb/infrun.c:5572
#36 0x0000aaaaaae9dde0 in fetch_inferior_event (client_data=0x0) at
../../../repos/binutils-gdb/gdb/infrun.c:4023
#37 0x0000aaaaaae80198 in inferior_event_handler (event_type=INF_REG_EVENT,
client_data=0x0) at ../../../repos/binutils-gdb/gdb/inf-loop.c:43
#38 0x0000aaaaaaea9f98 in infrun_async_inferior_event_handler (data=0x0) at
../../../repos/binutils-gdb/gdb/infrun.c:9371
#39 0x0000aaaaaae1b260 in check_async_event_handlers () at
../../../repos/binutils-gdb/gdb/event-loop.c:1032
#40 0x0000aaaaaae197c4 in gdb_do_one_event () at
../../../repos/binutils-gdb/gdb/event-loop.c:292
#41 0x0000aaaaaae198ac in start_event_loop () at
../../../repos/binutils-gdb/gdb/event-loop.c:337
#42 0x0000aaaaaaf0f11c in captured_command_loop () at
../../../repos/binutils-gdb/gdb/main.c:360
#43 0x0000aaaaaaf10a80 in captured_main (data=0xfffffffff1f0) at
../../../repos/binutils-gdb/gdb/main.c:1198
#44 0x0000aaaaaaf10ae8 in gdb_main (args=0xfffffffff1f0) at
../../../repos/binutils-gdb/gdb/main.c:1213
#45 0x0000aaaaaab8fe1c in main (argc=6, argv=0xfffffffff348) at
../../../repos/binutils-gdb/gdb/gdb.c:32


Things seem to derail starting from frame #14.

This doesn't seem to happen for x86 because it implements a gdbarch_unwind_pc
method, which aarch64 and, as far as i can tell, s390x doesn't.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

--- Comment #5 from Luis Machado <luis.machado at linaro dot org> ---
This may be a gcc bug for aarch64-linux.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #6 from Luis Machado <luis.machado at linaro dot org> ---
Patch sent.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |luis.machado at linaro dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Luis Machado <luis.machado at linaro dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/25649] [AArch64] Regressions on gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25649

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Luis Machado <luis.machado at linaro dot org> ---
Closing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.