[Bug symtab/25834] New: [cc-with-gdb-index] FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt (file1.txt seen more than once)

[Bug symtab/25834] New: [cc-with-gdb-index] FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt (file1.txt seen more than once)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25834

            Bug ID: 25834
           Summary: [cc-with-gdb-index] FAIL: gdb.dwarf2/dup-psym.exp:
                    info sources should contain only one reference to
                    file1.txt (file1.txt seen more than once)
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

This looks like a regression, used to pass at gdb-8.3-branch branchpoint.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25834] [cc-with-gdb-index] FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt (file1.txt seen more than once)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25834

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Test-case is for patch:
https://sourceware.org/legacy-ml/gdb-patches/2004-10/msg00298.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25834] [cc-with-gdb-index] FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt (file1.txt seen more than once)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25834

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simark at simark dot ca,
                   |                            |tromey at sourceware dot org

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Bisects to:

commit aa3916548076c159ae00a922690694094a37fcd0
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Jul 18 12:27:16 2019 -0600

    Fix latent bug in .debug_names file-name handling

    An internal Ada test case showed that the .debug_names code does not
    compute the same list of file names as the partial symbol reader.  In
    particular, the partial symbol reader uses the DW_AT_name of the CU:

      /* Allocate a new partial symbol table structure.  */
      filename = dwarf2_string_attr (comp_unit_die, DW_AT_name, cu);
      if (filename == NULL)
        filename = "";

      pst = create_partial_symtab (per_cu, filename);

    This patch changes the .debug_names reader to follow.

    gdb/ChangeLog
    2019-09-10  Tom Tromey  <tromey@adacore.com>

            * dwarf2read.c (dw2_get_file_names_reader): Add the
            CU's file name to the results.

    gdb/testsuite/ChangeLog
    2019-09-10  Tom Tromey  <tromey@adacore.com>

            * gdb.ada/dgopt.exp: New file.
            * gdb.ada/dgopt/x.adb: New file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25834] [cc-with-gdb-index,cc-with-debug-names] FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt (file1.txt seen more than once)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25834

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[cc-with-gdb-index] FAIL:   |[cc-with-gdb-index,cc-with-
                   |gdb.dwarf2/dup-psym.exp:    |debug-names] FAIL:
                   |info sources should contain |gdb.dwarf2/dup-psym.exp:
                   |only one reference to       |info sources should contain
                   |file1.txt (file1.txt seen   |only one reference to
                   |more than once)             |file1.txt (file1.txt seen
                   |                            |more than once)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25834] [cc-with-gdb-index,cc-with-debug-names] FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt (file1.txt seen more than once)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25834

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/gdb-patches/2021-July/180679.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25834] [cc-with-gdb-index,cc-with-debug-names] FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt (file1.txt seen more than once)

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25834

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25834] [cc-with-gdb-index,cc-with-debug-names] FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt (file1.txt seen more than once)

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25834

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1fd5fd5817dee816f30d0573b2d0ca1affb62836

commit 1fd5fd5817dee816f30d0573b2d0ca1affb62836
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Jul 4 13:48:33 2021 -0600

    Fix file-name handling regression with DWARF index

    When run with the gdb-index or debug-names target boards, dup-psym.exp
    fails.  This came up for me because my new DWARF scanner reuses this
    part of the existing index code, and so it registers as a regression.
    This is PR symtab/25834.

    Looking into this, I found that the DWARF index code here is fairly
    different from the psymtab code.  I don't think there's a deep reason
    for this, and in fact, it seemed to me that the index code could
    simply mimic what the psymtab code already does.

    That is what this patch implements.  The DW_AT_name and DW_AT_comp_dir
    are now stored in the quick file names table.  This may require
    allocating a quick file names table even when DW_AT_stmt_list does not
    exist.  Then, the functions that work with this data are changed to
    use find_source_or_rewrite, just as the psymbol code does.  Finally,
    line_header::file_full_name is removed, as it is no longer needed.

    Currently, the index maintains a hash table of "quick file names".
    The hash table uses a deletion function to free the "real name"
    components when necessary.  There's also a second such function to
    implement the forget_cached_source_info method.

    This bug fix patch will create a quick file name object even when
    there is no DW_AT_stmt_list, meaning that the object won't be entered
    in the hash table.  So, this patch changes the memory management
    approach so that the entries are cleared when the per-BFD object is
    destroyed.  (A dwarf2_per_cu_data destructor is not introduced,
    because we have been avoiding adding a vtable to that class.)

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=25834

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/25834] [cc-with-gdb-index,cc-with-debug-names] FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt (file1.txt seen more than once)

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25834

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
I think this was fixed a while ago but I forgot to close it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.