public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/25858] [readnow] FAIL: gdb.ada/bp_c_mixed_case.exp: break <NoDebugMixedCaseFunc>
Date: Mon, 20 Apr 2020 15:29:53 +0000	[thread overview]
Message-ID: <bug-25858-4717-LvYwS0pMtc@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25858-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25858

--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #5)
> The compunit has no address map:
> ...
> (gdb) p *ps->get_compunit_symtab ()->blockvector
> $6 = {nblocks = 19, map = 0x0, block = {0x43d23e0}}
> ...
> despite  the fact that the CU has a DW_AT_ranges attribute:

This seems to be because cu->base_address has not been set. This is a tentative
patch to fix that:
...
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 41db511c85..601c710750 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -9584,6 +9584,8 @@ process_full_comp_unit (struct dwarf2_per_cu_data
*per_cu,
   addr = gdbarch_adjust_dwarf2_addr (gdbarch, highpc + baseaddr);
   static_block = cu->get_builder ()->end_symtab_get_static_block (addr, 0, 1);

+  dwarf2_find_base_address (cu->dies, cu);
+
   /* If the comp unit has DW_AT_ranges, it may have discontiguous ranges.
      Also, DW_AT_ranges may record ranges not belonging to any child DIEs
      (such as virtual method tables).  Record the ranges in STATIC_BLOCK's
...

This indeed fixes this:
...
(gdb) p blockvector_contains_pc (ps->get_compunit_symtab ().blockvector, pc)
$13 = 1
...

But I still run into the same warning.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-04-20 15:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  7:23 [Bug symtab/25858] New: " vries at gcc dot gnu.org
2020-04-20  7:56 ` [Bug symtab/25858] " vries at gcc dot gnu.org
2020-04-20  7:57 ` vries at gcc dot gnu.org
2020-04-20 13:49 ` vries at gcc dot gnu.org
2020-04-20 13:53 ` vries at gcc dot gnu.org
2020-04-20 15:03 ` vries at gcc dot gnu.org
2020-04-20 15:29 ` vries at gcc dot gnu.org [this message]
2020-04-20 15:52 ` vries at gcc dot gnu.org
2020-04-23  8:40 ` vries at gcc dot gnu.org
2020-06-05  6:02 ` vries at gcc dot gnu.org
2020-06-05  8:29 ` andrew.burgess at embecosm dot com
2020-10-22 11:03 ` vries at gcc dot gnu.org
2020-10-22 15:26 ` vries at gcc dot gnu.org
2020-10-26 19:31 ` vries at gcc dot gnu.org
2020-10-28 20:10 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25858-4717-LvYwS0pMtc@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).