[Bug symtab/25858] [readnow] FAIL: gdb.ada/bp_c_mixed_case.exp: break <NoDebugMixedCaseFunc>

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=25858

--- Comment #12 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #4)
> (In reply to Tom de Vries from comment #3)
> > (In reply to Tom de Vries from comment #2)
> > > Tentative patch:
> > > ...
> > > diff --git a/gdb/symtab.c b/gdb/symtab.c
> > > index dc079efbc2..63a4b91f12 100644
> > > --- a/gdb/symtab.c
> > > +++ b/gdb/symtab.c
> > > @@ -2933,6 +2933,9 @@ find_pc_sect_compunit_symtab (CORE_ADDR pc, struct
> > > obj_section *section)
> > >           const struct blockvector *bv;
> > >  
> > >           bv = COMPUNIT_BLOCKVECTOR (cust);
> > > +         if (!blockvector_contains_pc (bv, pc))
> > > +           continue;
> > > +
> > >           b = BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK);
> > >  
> > >           if (BLOCK_START (b) <= pc
> > > ...
> > 
> > There must be some kind of invariant I'm breaking with the usage of
> > blockvector_contains_pc in the tentative patch, because this assert:
> > ...
> > diff --git a/gdb/block.c b/gdb/block.c
> > index 9b582433e4..bb21d72dbe 100644
> > --- a/gdb/block.c
> > +++ b/gdb/block.c
> > @@ -167,7 +167,10 @@ find_block_in_blockvector (const struct blockvector
> > *bl, CORE_ADDR pc)
> >      {
> >        b = BLOCKVECTOR_BLOCK (bl, bot);
> >        if (BLOCK_END (b) > pc)
> > -       return b;
> > +       {
> > +         gdb_assert (BLOCK_START (b) <= pc);
> > +         return b;
> > +       }
> >        bot--;
> >      }
> >  
> > ...
> > does not trigger on master, but if I build master with the tentative patch,
> > it triggers all the time in the testsuite (already counting 127 FAILs in
> > gdb.ada at gdb.ada/mi_interface.exp).
> 
> Tentative patch for this problem:
> ...
> diff --git a/gdb/block.c b/gdb/block.c
> index 9b582433e4..f883724d56 100644
> --- a/gdb/block.c
> +++ b/gdb/block.c
> @@ -166,7 +166,7 @@ find_block_in_blockvector (const struct blockvector *bl,
> CORE_ADDR pc)
>    while (bot >= STATIC_BLOCK)
>      {
>        b = BLOCKVECTOR_BLOCK (bl, bot);
> -      if (BLOCK_END (b) > pc)
> +      if (BLOCK_START (b) <= pc && pc < BLOCK_END (b))
>         return b;
>        bot--;
>      }
> ...

Committed a similar patch at
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=5fb4027fae1839cabbea75112c31bd89d46d2af0
.

-- 
You are receiving this mail because:
You are on the CC list for the bug.