[Bug testsuite/25996] New: wrap global arrays in namespace

[Bug testsuite/25996] New: wrap global arrays in namespace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25996

            Bug ID: 25996
           Summary: wrap global arrays in namespace
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

Created attachment 12543
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12543&action=edit
Generate warning when test-case defines global array

This ( https://sourceware.org/pipermail/gdb-patches/2020-May/168543.html ) is
an example where a test-case defines a global array, which clashes with a
scalar variable with the same name, defined in another test-case.

The way this was fixed was by wrapping the test-case in a namespace and
declaring the variable as a namespace variable using "variable".

It could be a good cleanup to proactively treat all global array vars as such.

I wrote a runtest.exp patch that detects test-cases that define global arrays,
which gives this type of output:
...
$ sed 's%/.*/gdb/testsuite/%%' build/CHECKLOG.gdb | grep WARNING
WARNING: gdb.ada/info_auto_lang.exp defined global array type_in_c
WARNING: gdb.ada/info_auto_lang.exp defined global array var_in_ada
WARNING: gdb.ada/info_auto_lang.exp defined global array rbreak_func_in_c
WARNING: gdb.ada/info_auto_lang.exp defined global array func_in_c
WARNING: gdb.ada/info_auto_lang.exp defined global array type_in_ada
WARNING: gdb.ada/info_auto_lang.exp defined global array rbreak_func_in_ada
WARNING: gdb.ada/info_auto_lang.exp defined global array var_in_c
WARNING: gdb.ada/info_auto_lang.exp defined global array func_in_ada
WARNING: gdb.arch/amd64-byte.exp defined global array byte_regs
WARNING: gdb.arch/amd64-dword.exp defined global array dword_regs
WARNING: gdb.arch/amd64-word.exp defined global array word_regs
WARNING: gdb.arch/i386-biarch-core.exp defined global array corestat
WARNING: gdb.arch/i386-byte.exp defined global array byte_regs
WARNING: gdb.arch/i386-word.exp defined global array word_regs
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/25996] wrap global arrays in namespace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25996

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
For a full test run, a total of 161 warnings in 34 test-cases.

Test-cases:
...
$ grep "^WARNING:.*defined global array" gdb.sum \
  | sed 's%.*/gdb/testsuite/%%' \
  | awk '{print $1}' \
  | sort -u 
gdb.ada/info_auto_lang.exp
gdb.arch/amd64-byte.exp
gdb.arch/amd64-dword.exp
gdb.arch/amd64-word.exp
gdb.arch/i386-biarch-core.exp
gdb.arch/i386-byte.exp
gdb.arch/i386-word.exp
gdb.base/charset.exp
gdb.base/consecutive-step-over.exp
gdb.base/coredump-filter.exp
gdb.base/many-completions.exp
gdb.base/savedregs.exp
gdb.base/step-over-syscall.exp
gdb.base/term.exp
gdb.base/watchpoint-unaligned.exp
gdb.cp/classes.exp
gdb.cp/cpexprs-debug-types.exp
gdb.cp/cpexprs.exp
gdb.cp/derivation.exp
gdb.cp/inherit.exp
gdb.cp/meth-typedefs.exp
gdb.cp/nested-types.exp
gdb.cp/ovldbreak.exp
gdb.cp/ptype-flags.exp
gdb.cp/rvalue-ref-overload.exp
gdb.cp/virtfunc.exp
gdb.dwarf2/clztest.exp
gdb.dwarf2/typeddwarf.exp
gdb.linespec/ls-errs.exp
gdb.mi/mi2-var-child.exp
gdb.mi/mi-var-cp.exp
gdb.python/py-typeprint.exp
gdb.threads/tls.exp
gdb.xml/tdesc-regs.exp
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/25996] wrap global arrays in namespace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25996

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Warnings:
...
$ sed 's%/.*/gdb/testsuite/%%' build/CHECKLOG.gdb \
  | grep WARNING
WARNING: gdb.ada/info_auto_lang.exp defined global array type_in_c
WARNING: gdb.ada/info_auto_lang.exp defined global array var_in_ada
WARNING: gdb.ada/info_auto_lang.exp defined global array rbreak_func_in_c
WARNING: gdb.ada/info_auto_lang.exp defined global array func_in_c
WARNING: gdb.ada/info_auto_lang.exp defined global array type_in_ada
WARNING: gdb.ada/info_auto_lang.exp defined global array rbreak_func_in_ada
WARNING: gdb.ada/info_auto_lang.exp defined global array var_in_c
WARNING: gdb.ada/info_auto_lang.exp defined global array func_in_ada
WARNING: gdb.arch/amd64-byte.exp defined global array byte_regs
WARNING: gdb.arch/amd64-dword.exp defined global array dword_regs
WARNING: gdb.arch/amd64-word.exp defined global array word_regs
WARNING: gdb.arch/i386-biarch-core.exp defined global array corestat
WARNING: gdb.arch/i386-byte.exp defined global array byte_regs
WARNING: gdb.arch/i386-word.exp defined global array word_regs
WARNING: gdb.base/charset.exp defined global array charsets
WARNING: gdb.base/consecutive-step-over.exp defined global array bp_addrs
WARNING: gdb.base/coredump-filter.exp defined global array coredump_var_addr
WARNING: gdb.base/many-completions.exp defined global array all_funcs
WARNING: gdb.base/savedregs.exp defined global array saved_regs
WARNING: gdb.base/step-over-syscall.exp defined global array syscall_number
WARNING: gdb.base/term.exp defined global array termios1
WARNING: gdb.base/term.exp defined global array termios2
WARNING: gdb.base/term.exp defined global array termios3
WARNING: gdb.base/watchpoint-unaligned.exp defined global array
wpoffset_to_wpnum
WARNING: gdb.base/watchpoint-unaligned.exp defined global array alignedend
WARNING: gdb.cp/classes.exp defined global array auto_index
WARNING: gdb.cp/classes.exp defined global array cp_class_table_history
WARNING: gdb.cp/cpexprs-debug-types.exp defined global array all_functions
WARNING: gdb.cp/cpexprs.exp defined global array all_functions
WARNING: gdb.cp/derivation.exp defined global array cp_class_table_history
WARNING: gdb.cp/inherit.exp defined global array cp_class_table_history
WARNING: gdb.cp/meth-typedefs.exp defined global array typedefs
WARNING: gdb.cp/nested-types.exp defined global array cp_class_table_history
WARNING: gdb.cp/ovldbreak.exp defined global array arguments
WARNING: gdb.cp/ovldbreak.exp defined global array might_fail
WARNING: gdb.cp/ovldbreak.exp defined global array type_map
WARNING: gdb.cp/ptype-flags.exp defined global array cp_class_table_history
WARNING: gdb.cp/rvalue-ref-overload.exp defined global array
cp_class_table_history
WARNING: gdb.cp/virtfunc.exp defined global array cp_class_table_history
WARNING: gdb.dwarf2/clztest.exp defined global array tests
WARNING: gdb.dwarf2/typeddwarf.exp defined global array tests
WARNING: gdb.linespec/ls-errs.exp defined global array error_messages
WARNING: gdb.mi/mi-var-cp.exp defined global array root.a1.public.1_anonymous
WARNING: gdb.mi/mi-var-cp.exp defined global array root
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.d
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.0_anonymous.public
WARNING: gdb.mi/mi-var-cp.exp defined global array root.a1.public.0_anonymous
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.2_anonymous.public.i
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.2_anonymous.public.j
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.1_anonymous.public
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.2_anonymous
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.1_anonymous.public.1_anonymous
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.0_anonymous.public.b
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.1_anonymous.public.1_anonymous.public
WARNING: gdb.mi/mi-var-cp.exp defined global array root.a1
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.1_anonymous
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.1_anonymous.public
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.1_anonymous.public.1_anonymous.public.g
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.1_anonymous.public.1_anonymous.public.h
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.1_anonymous.public.c
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.1_anonymous.public.f
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.e
WARNING: gdb.mi/mi-var-cp.exp defined global array
root.a1.public.2_anonymous.public.1_anonymous.public.2_anonymous.public
WARNING: gdb.mi/mi-var-cp.exp defined global array root.a1.public.2_anonymous
WARNING: gdb.mi/mi-var-cp.exp defined global array root.a1.public
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u1.b.b
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.a1
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.a1.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.b1
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u2.b3.b
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u2.a3
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u2.b3
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var21.ab
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ptr1.*ptr
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u2.a3.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u2.a3
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u2.b3
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u1.a.a
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.d
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.e
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.f
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u1
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u2
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.char_ptr
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.a1.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u1.b.b
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u1.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u1.b
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.3_anonymous
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ptr1
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u2.a3.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.a1
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var21.ab.a.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.b1
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ss_ptr1.3_anonymous.b2.b
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var21.ab.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var21.ab.b
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.g
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.h
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var21.ab.b.b
WARNING: gdb.mi/mi2-var-child.exp defined global array root.v1.1_anonymous.a
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.0
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.1
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.2
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.3
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.4
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.5
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.6
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.7
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.8
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.array_of_10.9
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.var1.3_anonymous.b2.b
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u1.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.u1.b
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.c.*c
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.character
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u1
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u2
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.h.*h
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.3_anonymous.a2
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.3_anonymous.b2
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.3_anonymous
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.h.*h.**h
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.signed_character
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ss_ptr1.3_anonymous.a2.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ptr1.*ptr.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.v1.2_anonymous.b
WARNING: gdb.mi/mi2-var-child.exp defined global array root.v1
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.b
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.c
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.var1.3_anonymous.a2.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.b1.b
WARNING: gdb.mi/mi2-var-child.exp defined global array root.v1.x
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var21
WARNING: gdb.mi/mi2-var-child.exp defined global array root.v1.2_anonymous
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.unsigned_integer
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u2.b3.b
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.char_ptr.*char_ptr
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ss_ptr1.3_anonymous.a2
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ss_ptr1.3_anonymous.b2
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous.3_anonymous.simple.*simple.**simple.integer
WARNING: gdb.mi/mi2-var-child.exp defined global array root.var1.u1.a.a
WARNING: gdb.mi/mi2-var-child.exp defined global array root.v1.1_anonymous
WARNING: gdb.mi/mi2-var-child.exp defined global array root.ss_ptr1.b1.b
WARNING: gdb.mi/mi2-var-child.exp defined global array
root.ptr1.*ptr.1_anonymous.2_anonymous
WARNING: gdb.python/py-typeprint.exp defined global array
cp_class_table_history
WARNING: gdb.threads/tls.exp defined global array spin_threads_level
WARNING: gdb.threads/tls.exp defined global array spin_threads
WARNING: gdb.xml/tdesc-regs.exp defined global array remote_filename
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/25996] wrap global arrays in namespace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25996

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
Updated patch, not in runtest.exp:
https://sourceware.org/pipermail/gdb-patches/2020-May/168608.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/25996] wrap global arrays in namespace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25996

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed slightly differently by:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a29d5112814e7a6744f03bddfe6756e2aa5e7a50

-- 
You are receiving this mail because:
You are on the CC list for the bug.