[Bug gdb/26081] New: Function names in source window are always black source style turned on

[Bug gdb/26081] New: Function names in source window are always black source style turned on

[petedietl at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

            Bug ID: 26081
           Summary: Function names in source window are always black
                    source style turned on
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: petedietl at gmail dot com
  Target Milestone: ---

Created attachment 12586
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12586&action=edit
GDB window

I can't see the names of the functions in the TUI src window since they are
colored black. But the color looks correct in the asm window. Changing the
function style foreground color does change the function names in the asm
window but still no changes in the src window.

I didn't have these issues when I was using an older v10 from source. Though I
don't recall exactly which version I used. 

The color scheme looks weird in general now. I have attached a screen shot. 

Environment Details:
Linux pdietl-dev 5.4.0-33-generic #37-Ubuntu SMP Thu May 21 12:53:59 UTC 2020
x86_64 x86_64 x86_64 GNU/Linux

GNU gdb (GDB) 10.0.50.20200603-git

This GDB was configured as follows:
   configure --host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
             --with-auto-load-dir=$debugdir:$datadir/auto-load
             --with-auto-load-safe-path=$debugdir:$datadir/auto-load
             --with-expat
             --with-gdb-datadir=/usr/local/share/gdb (relocatable)
             --with-jit-reader-dir=/usr/local/lib/gdb (relocatable)
             --without-libunwind-ia64
             --without-lzma
             --without-babeltrace
             --without-intel-pt
             --with-mpfr
             --with-xxhash
             --with-python=/usr
             --without-debuginfod
             --without-guile
             --enable-source-highlight
             --with-separate-debug-dir=/usr/local/lib/debug (relocatable)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26081] Function names in source window are always black source style turned on

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ssbssa at sourceware dot org

--- Comment #1 from Hannes Domani <ssbssa at sourceware dot org> ---
The colors of the src window can not be configured in gdb, they are coming from
the source-highlight library.

gdb uses esc.style for the color scheme, which has "black b" (black bold) for
functions, which should be dark grey.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26081] Function names in source window are always black source style turned on

[petedietl at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

--- Comment #2 from Pete Dietl <petedietl at gmail dot com> ---
You can change the colors via 
Set style functions <color>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26081] Function names in source window are always black source style turned on

[petedietl at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

--- Comment #3 from Pete Dietl <petedietl at gmail dot com> ---
You can change the colors via 
Set style functions <color>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26081] Function names in source window are always black source style turned on

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
That "set style" command does not affect the source highlighting.
Maybe it should though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26081] Function names in source window are always black source style turned on

[petedietl at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

--- Comment #5 from Pete Dietl <petedietl at gmail dot com> ---
(In reply to Tom Tromey from comment #4)
> That "set style" command does not affect the source highlighting.
> Maybe it should though.

That’s interesting, since it does affect the asm highlighting...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26081] Function names in source window are always black source style turned on

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
Yeah, asm highlighting isn't done by the source highlight library.
That library is only used for source code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26081] Function names in source window are always black source style turned on

[petedietl at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

--- Comment #7 from Pete Dietl <petedietl at gmail dot com> ---
(In reply to Tom Tromey from comment #6)
> Yeah, asm highlighting isn't done by the source highlight library.
> That library is only used for source code.

Interesting. Why is this the case?

Anyway, so what I am hearing that is this is the result of libhighlight being
weird and not GDB.+

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26081] Function names in source window are always black source style turned on

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Pete Dietl from comment #7)
> (In reply to Tom Tromey from comment #6)
> > Yeah, asm highlighting isn't done by the source highlight library.
> > That library is only used for source code.
> 
> Interesting. Why is this the case?

Maybe there isn't a great reason.  I didn't think about it
at the time, but I see source highlight does handle asm.
Though, it only seems to handle x86.  And maybe we could
do even better in gdb by using some features that were
added to binutils.

> 
> Anyway, so what I am hearing that is this is the result of libhighlight
> being weird and not GDB.+

Also, the "black" thing was fixed in source highlight.
I forgot about this.  Make sure you have the latest release.
It was fixed here:

commit b4fc95d90a702d2001369d68d0972a43caa172be
Author: Tom Tromey <tom@tromey.com>
Date:   Sat Jun 1 13:42:36 2019 -0600

    Don't use "black" in esc.style

    Bug #55967 points out that using "black" in the function style in
    esc.style makes function names unreadable on a dark-theme
    terminal. The suggested fix, removing "black", seemed reasonable to
    me, so I am checking it in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/26081] Function names in source window are always black source style turned on

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26081

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdb                         |tui

-- 
You are receiving this mail because:
You are on the CC list for the bug.