[Bug rust/26121] New: FAIL: gdb.rust/modules.exp: print ::TWENTY_THREE

[Bug rust/26121] New: FAIL: gdb.rust/modules.exp: print ::TWENTY_THREE

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26121

            Bug ID: 26121
           Summary: FAIL: gdb.rust/modules.exp: print ::TWENTY_THREE
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: rust
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

With test-case gdb.rust/modules.exp, I run into:
...
(gdb) PASS: gdb.rust/modules.exp: setting breakpoint at *::f2
print ::TWENTY_THREE^M
No symbol '::modules::TWENTY_THREE' in current context^M
(gdb) FAIL: gdb.rust/modules.exp: print ::TWENTY_THREE
...

This is using:
...
$ rustc --version
rustc 1.43.0
...

The commit adding the test mentions:
...
    (Note that there are unrelated failures with newer
    versions of rustc; I will be addressing those separately.)
...
So, perhaps this FAIL is on of those unrelated failures.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/26121] FAIL: gdb.rust/modules.exp: print ::TWENTY_THREE

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26121

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 12666
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12666&action=edit
exec: modules.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/26121] FAIL: gdb.rust/modules.exp: print ::TWENTY_THREE

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26121

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
patch submitted:
https://sourceware.org/pipermail/gdb-patches/2020-July/170141.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/26121] FAIL: gdb.rust/modules.exp: print ::TWENTY_THREE

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26121

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0ed35c9ae0434dcda2d5d3e3f0be77fa1f323283

commit 0ed35c9ae0434dcda2d5d3e3f0be77fa1f323283
Author: Daniel Xu <dxu@dxuuu.xyz>
Date:   Fri Jul 3 20:59:53 2020 -0700

    rust: Fix rust modules test

    I noticed that the modules test was failing. Some choice use of `nm`
    revealed `TWENTY_THREE` was not in the final binary. Fix by taking a
    pointer to the global, forcing the linker to keep the symbol in.

    gdb/testsuite/ChangeLog
    2020-07-11  Daniel Xu  <dxu@dxuuu.xyz>

            PR rust/26121
            * gdb.rust/modules.rs: Prevent linker from discarding test
            symbol.

    Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/26121] FAIL: gdb.rust/modules.exp: print ::TWENTY_THREE

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26121

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |10.1
             Status|NEW                         |RESOLVED
                 CC|                            |tromey at sourceware dot org

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.