[Bug build/26183] GDB build fails with error: ‘class std::basic_string_view<char>’ has no member named ‘to_string’

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=26183

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5ac588997c3c2d032d5d5145d9245eb37354c23b

commit 5ac588997c3c2d032d5d5145d9245eb37354c23b
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Jun 30 07:53:03 2020 -0600

    Do not define basic_string_view::to_string

    gdb's copy of basic_string_view includes a to_string method.  However,
    according to cppreference, this is not a method on the real
    std::basic_string_view:

    https://en.cppreference.com/w/cpp/string/basic_string_view

    This difference matters because gdb_string_view.h will use the
    standard implementation when built with a C++17 or later.  This caused
    PR build/26183.

    This patch fixes the problem by changing the method to be a standalone
    helper function, and then rewriting the uses.  Tested by rebuilding
    with a version of GCC that defaults to C++17.

    (Note that the build still is not clean; and also I noticed that the
    libstdc++ string_view forbids the use of nullptr ... I wonder if gdb
    violates that.)

    gdb/ChangeLog
    2020-06-30  Tom Tromey  <tromey@adacore.com>

            PR build/26183:
            * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
            gdb::to_string.

    gdbsupport/ChangeLog
    2020-06-30  Tom Tromey  <tromey@adacore.com>

            PR build/26183:
            * gdb_string_view.h (basic_string_view::to_string): Remove.
            (gdb::to_string): New function.

-- 
You are receiving this mail because:
You are on the CC list for the bug.