[Bug corefiles/26289] New: Infinite loop in dwarf2_attr()

[Bug corefiles/26289] New: Infinite loop in dwarf2_attr()

[leandro at hardinfo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26289

            Bug ID: 26289
           Summary: Infinite loop in dwarf2_attr()
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: corefiles
          Assignee: unassigned at sourceware dot org
          Reporter: leandro at hardinfo dot org
  Target Milestone: ---

Created attachment 12719
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12719&action=edit
Patch (version 1)

While debugging a program that dumped core (which I unfortunately can't share),
GDB gets into an infinite loop inside dwarf2_attr() because the ``die''
returned by follow_die_ref() is the same one that was passed in.

Attached is a patch that addresses this issue, but I'm not familiar with GDB or
DWARF enough to reason about it, so feedback would be appreciated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug corefiles/26289] Infinite loop in dwarf2_attr()

[leandro at hardinfo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26289

Leandro Pereira <leandro at hardinfo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12719|0                           |1
        is obsolete|                            |

--- Comment #1 from Leandro Pereira <leandro at hardinfo dot org> ---
Created attachment 12720
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12720&action=edit
Patch (version 1, but with the correct email address)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug corefiles/26289] Infinite loop in dwarf2_attr()

[andrew.burgess at embecosm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26289

Andrew Burgess <andrew.burgess at embecosm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.burgess at embecosm dot com

--- Comment #2 from Andrew Burgess <andrew.burgess at embecosm dot com> ---
Created attachment 12721
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12721&action=edit
Extended patch including test case

This started out with me "just" writing a test case for this issue. 
Unfortunately this exposed a bunch more places that needed fixing up, so this
is now the original patch + a test case + some additional fixes.

This is still work-in-progress, but the code needs a clean up, and I suspect
that there might be additional test cases that need to be written.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug corefiles/26289] Infinite loop in dwarf2_attr()

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26289

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
FWIW it's good, when possible, to print info about which DIE is
offending.
Here's an example:
          complaint (_("Computed physname <%s> does not match demangled <%s> "
                       "(from linkage <%s>) - DIE at %s [in module %s]"),
                     physname, canon, mangled, sect_offset_str (die->sect_off),
                     objfile_name (objfile));
That way it is sometimes simpler to track down the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/26289] Infinite loop in dwarf2_attr()

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26289

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|corefiles                   |symtab

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Switching components.

-- 
You are receiving this mail because:
You are on the CC list for the bug.