[Bug d/26597] New: FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv

[Bug d/26597] New: FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26597

            Bug ID: 26597
           Summary: FAIL: gdb.dlang/demangle.exp:
                    _D8demangle4testFI5identZv
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: d
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

Recent regressions:
...
FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv
FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5ident4testZv
...

In more detail:
...
(gdb) PASS: gdb.dlang/demangle.exp: _D8demangle4testFNhG4dZv
demangle _D8demangle4testFI5identZv^M
Can't demangle "_D8demangle4testFI5identZv"^M
(gdb) FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv
demangle _D8demangle4testFI5ident4testZv^M
Can't demangle "_D8demangle4testFI5ident4testZv"^M
(gdb) FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5ident4testZv
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug d/26597] FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26597

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amodra at gmail dot com

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
There's a recent sync from libiberty that contains changes to d-demangle.c:
...
commit 7ade7fba756326c5f35f53a8e2d46443c6bab73f
Author: Alan Modra <amodra@gmail.com>
Date:   Tue Sep 8 18:57:15 2020 +0930

    sync libiberty from gcc

    config/
            Sync from gcc
            2020-07-15  H.J. Lu  <hjl.tools@gmail.com>
            PR bootstrap/96202
            * cet.m4 (GCC_CET_HOST_FLAGS): Don't enable CET without CET
            support in stage1 nor for build support.
    libiberty/
            * configure: Regenerate.

            Sync from gcc
            2020-09-08  Alan Modra  <amodra@gmail.com>
            * d-demangle.c: Include limits.h.
            (ULONG_MAX, UINT_MAX): Provide fall-back definition.
            (dlang_number): Simplify and correct overflow test.  Only
            write *ret on returning non-NULL.  Make "ret" an unsigned long*.
            Only succeed for result of [0,UINT_MAX].
            (dlang_decode_backref): Simplify and correct overflow test.
            Only write *ret on returning non-NULL.  Only succeed for
            result [1,MAX_LONG].
            (dlang_backref): Remove now unnecessary range check.
            (dlang_symbol_name_p): Likewise.
            (string_need): Take a size_t n arg, and use size_t tem.
            (string_append): Use size_t n.
            (string_appendn, string_prependn): Take a size_t n arg.
            (TEMPLATE_LENGTH_UNKNOWN): Define as -1UL.
            (dlang_lname, dlang_parse_template): Take an unsigned long len
            arg.
            (dlang_symbol_backref, dlang_identifier, dlang_parse_integer),
            (dlang_parse_integer, dlang_parse_string),
            (dlang_parse_arrayliteral, dlang_parse_assocarray),
            (dlang_parse_structlit, dlang_parse_tuple),
            (dlang_template_symbol_param, dlang_template_args): Use
            unsigned long variables.
            * testsuite/d-demangle-expected: Add new tests.

            2020-08-04  Iain Buclaw  <ibuclaw@gdcproject.org>
            * d-demangle.c (dlang_function_args): Handle 'in' and 'in ref'
            parameter storage classes.
            (dlang_type): Remove identifier type.
            * testsuite/d-demangle-expected: Update tests.

            2020-08-03  Richard Biener  <rguenther@suse.de>
            PR lto/96385
            * simple-object-elf.c
            (simple_object_elf_copy_lto_debug_sections): Localize global
            UNDEFs and reuse the prevailing name.

            2020-07-10  Ian Lance Taylor  <iant@golang.org>
            PR demangler/96143
            * cp-demangle.c (d_lambda): Don't add substitution candidate.
            * testsuite/demangle-expected: Update a few existing test cases
            accordingly, and add a new test case.

            2020-07-04  Jason Merrill  <jason@redhat.com>
            * cp-demangle.c (cplus_demangle_operators): Add di, dx, dX.
            (d_expression_1): Handle di and dX.
            (is_designated_init, d_maybe_print_designated_init): New.
            (d_print_comp_inner): Use d_maybe_print_designated_init.
            * testsuite/demangle-expected: Add designator tests.

            2020-06-25  Nick Clifton  <nickc@redhat.com>
            * bsearch.c (bsearch): Remove use of register keyword.
            * bsearch_r.c (bsearch_r): Likewise.
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug d/26597] FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv

[amodra at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26597

--- Comment #2 from Alan Modra <amodra at gmail dot com> ---
This will be gcc commit 387d0773f39a56b2a831a2b7e7ed189d6ffc2f36.  The tests
are no longer valid.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug d/26597] FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv

[cbiesinger at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26597

Christian Biesinger <cbiesinger at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbiesinger at google dot com

--- Comment #3 from Christian Biesinger <cbiesinger at google dot com> ---
(for convenience,
https://github.com/gcc-mirror/gcc/commit/387d0773f39a56b2a831a2b7e7ed189d6ffc2f36)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug d/26597] FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv

[amodra at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26597

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |amodra at gmail dot com
             Status|NEW                         |ASSIGNED

--- Comment #4 from Alan Modra <amodra at gmail dot com> ---
Created attachment 12831
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12831&action=edit
update test

This makes the same change to the gdb testsuite as was done upstream in the gcc
libiberty test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug d/26597] FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26597

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alan Modra <amodra@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=918619e5e591c492b1a67f8ce125aa8728eb4497

commit 918619e5e591c492b1a67f8ce125aa8728eb4497
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Sep 10 23:46:11 2020 +0930

    PR26597, FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv

    gcc commit 387d0773f3 changed the D demangler, with the following
    commit log:

        libiberty: Add support for `in' and `in ref' storage classes.

        The storage class `in' is now a first-class citizen with its own mangle
        symbol, of which also permits `in ref'.  Previously, `in' was an alias
        to `const [scope]', which is a type constructor.

        The mangle symbol repurposed for this is `I', which was originally used
        by identifier types.  However, while TypeIdentifier is part of the
        grammar, it must be resolved to some other entity during the semantic
        passes, and so shouldn't appear anywhere in the mangled name.

        Old tests that are now no longer valid have been removed.

    This patch makes the same changes to the gdb testsuite as were made to
    the upstream gcc libiberty testsuite.

    gdb/testsuite/
            PR 26597
            * gdb.dlang/demangle.exp: Update tests as per gcc commit
387d0773f3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug d/26597] FAIL: gdb.dlang/demangle.exp: _D8demangle4testFI5identZv

[amodra at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26597

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|amodra at gmail dot com            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Alan Modra <amodra at gmail dot com> ---
Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.