public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/26618] New: UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: }
@ 2020-09-15 14:33 vries at gcc dot gnu.org
2020-09-15 18:02 ` [Bug testsuite/26618] " tromey at sourceware dot org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-15 14:33 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26618
Bug ID: 26618
Summary: UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted
due to invalid command name: }
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: testsuite
Assignee: unassigned at sourceware dot org
Reporter: vries at gcc dot gnu.org
Target Milestone: ---
There are some problems with a gdb.tui test-case on SLE-11:
...
$ grep -c "UNRESOLVED:.*new-layout.exp"
binaries-testsuite.*/usr/share/doc/packages/gdb-testresults/*.sum | grep -v
:0
binaries-testsuite.SLE-11.i586/usr/share/doc/packages/gdb-testresults/gdb-i586-suse-linux-m32.-fPIE.-pie.sum:5
binaries-testsuite.SLE-11.i586/usr/share/doc/packages/gdb-testresults/gdb-i586-suse-linux-m32.sum:5
binaries-testsuite.SLE-11.x86_64/usr/share/doc/packages/gdb-testresults/gdb-x86_64-suse-linux-m64.-fPIE.-pie.sum:5
binaries-testsuite.SLE-11.x86_64/usr/share/doc/packages/gdb-testresults/gdb-x86_64-suse-linux-m64.sum:5
...
In more detail:
...
(gdb) PASS: gdb.tui/new-layout.exp: tui new-layout example src 1
UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command
name: }
ERROR: Couldn't send tui new-layout example src 1} to GDB.
UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example src 1}
UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command
name: }
DUPLICATE: gdb.tui/new-layout.exp: testcase aborted due to invalid command
name: }
ERROR: Couldn't send tui new-layout example {src 1} 1} to GDB.
UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example {src 1} 1}
ERROR: Couldn't send tui new-layout example {src 1 to GDB.
UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example {src 1
...
Used versions:
...
DejaGnu version: 1.4.4
Expect version: 5.44.1.11
Tcl version: 8.5
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug testsuite/26618] UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: }
2020-09-15 14:33 [Bug testsuite/26618] New: UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: } vries at gcc dot gnu.org
@ 2020-09-15 18:02 ` tromey at sourceware dot org
2020-09-16 8:38 ` vries at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2020-09-15 18:02 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26618
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org
--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I couldn't reproduce with Tcl 8.6.
Maybe there are some unpaired { or } that need extra quoting for 8.5.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug testsuite/26618] UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: }
2020-09-15 14:33 [Bug testsuite/26618] New: UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: } vries at gcc dot gnu.org
2020-09-15 18:02 ` [Bug testsuite/26618] " tromey at sourceware dot org
@ 2020-09-16 8:38 ` vries at gcc dot gnu.org
2020-09-16 8:57 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-16 8:38 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26618
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #1)
> I couldn't reproduce with Tcl 8.6.
Yeah, me neither.
> Maybe there are some unpaired { or } that need extra quoting for 8.5.
I looked for an explanation on why that should be the case, but didn't find
any.
I currently don't have access to a setup with tcl 8.5 to reproduce and
investigate.
I remembered running into this (
https://sourceware.org/pipermail/gdb-patches/2020-June/169432.html ), so I
tried to flush out the unpaired braces using:
...
proc do_this { args } {
uplevel 1 {*}$args
}
do_this {
gdb_test ...
}
...
and that worked.
So, tentative patch:
...
diff --git a/gdb/testsuite/gdb.tui/new-layout.exp
b/gdb/testsuite/gdb.tui/new-layou
t.exp
index b4fca674e8..57c3f75e3b 100644
--- a/gdb/testsuite/gdb.tui/new-layout.exp
+++ b/gdb/testsuite/gdb.tui/new-layout.exp
@@ -42,12 +42,12 @@ gdb_test "tui new-layout example src 1 src 1" \
"Window \"src\" seen twice in layout"
gdb_test "tui new-layout example src 1" \
"New layout does not contain the \"cmd\" window"
-gdb_test "tui new-layout example src 1}" \
- "Extra '}' in layout specification"
-gdb_test "tui new-layout example {src 1} 1}" \
- "Extra '}' in layout specification"
-gdb_test "tui new-layout example {src 1" \
- "Missing '}' in layout specification"
+gdb_test "tui new-layout example src 1\}" \
+ "Extra '\}' in layout specification"
+gdb_test "tui new-layout example {src 1} 1\}" \
+ "Extra '\}' in layout specification"
+gdb_test "tui new-layout example \{src 1" \
+ "Missing '\}' in layout specification"
gdb_test_no_output "tui new-layout example asm 1 status 0 cmd 1"
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug testsuite/26618] UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: }
2020-09-15 14:33 [Bug testsuite/26618] New: UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: } vries at gcc dot gnu.org
2020-09-15 18:02 ` [Bug testsuite/26618] " tromey at sourceware dot org
2020-09-16 8:38 ` vries at gcc dot gnu.org
@ 2020-09-16 8:57 ` cvs-commit at gcc dot gnu.org
2020-09-16 9:03 ` vries at gcc dot gnu.org
2020-09-16 9:06 ` vries at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-16 8:57 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26618
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4d91ddd342b507a177fb84b73fdb6c0403323f79
commit 4d91ddd342b507a177fb84b73fdb6c0403323f79
Author: Tom de Vries <tdevries@suse.de>
Date: Wed Sep 16 10:57:17 2020 +0200
[gdb/testsuite] Fix unbalanced braces in gdb.tui/new-layout.exp
On SLE-11 with tcl version 8.5, we run into:
...
UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to \
invalid command name: }
ERROR: Couldn't send tui new-layout example src 1} to GDB.
...
Apparently tcl 8.6 is more forgiving about unbalanced braces.
Expose the unbalanced braces on tcl 8.6 by temporarily wrapping the
test-case in:
...
proc do_this { args } {
uplevel 1 {*}$args
}
do_this {
...
}
...
and escape them using a backslash.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2020-09-16 Tom de Vries <tdevries@suse.de>
PR testsuite/26618
* gdb.tui/new-layout.exp: Escape unbalanced braces.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug testsuite/26618] UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: }
2020-09-15 14:33 [Bug testsuite/26618] New: UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: } vries at gcc dot gnu.org
` (2 preceding siblings ...)
2020-09-16 8:57 ` cvs-commit at gcc dot gnu.org
@ 2020-09-16 9:03 ` vries at gcc dot gnu.org
2020-09-16 9:06 ` vries at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-16 9:03 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26618
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch committed, marking resolved-fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug testsuite/26618] UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: }
2020-09-15 14:33 [Bug testsuite/26618] New: UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: } vries at gcc dot gnu.org
` (3 preceding siblings ...)
2020-09-16 9:03 ` vries at gcc dot gnu.org
@ 2020-09-16 9:06 ` vries at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-16 9:06 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26618
--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch committed, marking resolved-fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-16 9:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 14:33 [Bug testsuite/26618] New: UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid command name: } vries at gcc dot gnu.org
2020-09-15 18:02 ` [Bug testsuite/26618] " tromey at sourceware dot org
2020-09-16 8:38 ` vries at gcc dot gnu.org
2020-09-16 8:57 ` cvs-commit at gcc dot gnu.org
2020-09-16 9:03 ` vries at gcc dot gnu.org
2020-09-16 9:06 ` vries at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).