public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug tui/26638] New: TUI focus behavior change
@ 2020-09-20 0:56 simark at simark dot ca
2020-09-20 14:32 ` [Bug tui/26638] " brobecker at gnat dot com
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: simark at simark dot ca @ 2020-09-20 0:56 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26638
Bug ID: 26638
Summary: TUI focus behavior change
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: tui
Assignee: unassigned at sourceware dot org
Reporter: simark at simark dot ca
Target Milestone: ---
Commit a30cb6dabb20 ("Derive tui_locator_window from tui_win_info") introduced
a behavior change regarding focus change in the TUI, I think it was not
expected.
Behavior before:
1. Start GDB with the tui enabled
2. Type "ctrl-x o" once to change the focus
3. Type any command
4. Hit up arrow: it brings back the previously typed command
Behavior after:
1. Start GDB with the tui enabled
2. Type "ctrl-x o" once to change the focus
3. Type any command
4. Hit up arrow: nothing happens
One suspicious sign is that before this patch, it takes two "ctrl-x o" to
cycles through the focusable views (code and prompt). After the patch, it
takes three. So it looks like there's a third hidden view that gets the focus.
I noticed this because I usually do "ctrl-x o" to change the focus to the
prompt, to be able to use the arrows to access the history of commands.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tui/26638] TUI focus behavior change
2020-09-20 0:56 [Bug tui/26638] New: TUI focus behavior change simark at simark dot ca
@ 2020-09-20 14:32 ` brobecker at gnat dot com
2020-09-23 18:47 ` tromey at sourceware dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: brobecker at gnat dot com @ 2020-09-20 14:32 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26638
Joel Brobecker <brobecker at gnat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |brobecker at gnat dot com
Target Milestone|--- |10.1
--- Comment #1 from Joel Brobecker <brobecker at gnat dot com> ---
FTR, I double-checked that commit a30cb6dabb20 is in the gdb-10-branch.
Changing the target milestone to 10.1
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tui/26638] TUI focus behavior change
2020-09-20 0:56 [Bug tui/26638] New: TUI focus behavior change simark at simark dot ca
2020-09-20 14:32 ` [Bug tui/26638] " brobecker at gnat dot com
@ 2020-09-23 18:47 ` tromey at sourceware dot org
2020-09-23 18:59 ` tromey at sourceware dot org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tromey at sourceware dot org @ 2020-09-23 18:47 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26638
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org
Assignee|unassigned at sourceware dot org |tromey at sourceware dot org
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tui/26638] TUI focus behavior change
2020-09-20 0:56 [Bug tui/26638] New: TUI focus behavior change simark at simark dot ca
2020-09-20 14:32 ` [Bug tui/26638] " brobecker at gnat dot com
2020-09-23 18:47 ` tromey at sourceware dot org
@ 2020-09-23 18:59 ` tromey at sourceware dot org
2020-09-24 19:02 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tromey at sourceware dot org @ 2020-09-23 18:59 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26638
--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2020-September/172029.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tui/26638] TUI focus behavior change
2020-09-20 0:56 [Bug tui/26638] New: TUI focus behavior change simark at simark dot ca
` (2 preceding siblings ...)
2020-09-23 18:59 ` tromey at sourceware dot org
@ 2020-09-24 19:02 ` cvs-commit at gcc dot gnu.org
2020-09-24 19:04 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-24 19:02 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26638
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b551a89f51504735e9979ac885a5784e21cfecef
commit b551a89f51504735e9979ac885a5784e21cfecef
Author: Tom Tromey <tromey@adacore.com>
Date: Wed Sep 23 12:57:19 2020 -0600
Don't let TUI focus on locator
PR tui/26638 notes that the C-x o binding can put the focus on the
locator window. However, this is not useful and did not happen
historically. This patch changes the TUI to skip this window when
switching focus.
gdb/ChangeLog
2020-09-24 Tom Tromey <tromey@adacore.com>
PR tui/26638:
* tui/tui-stack.h (struct tui_locator_window) <can_focus>: New
method.
* tui/tui-data.h (struct tui_win_info) <can_focus>: New method.
* tui/tui-data.c (tui_next_win): Exclude non-focusable windows.
(tui_prev_win): Rewrite.
gdb/testsuite/ChangeLog
2020-09-24 Tom Tromey <tromey@adacore.com>
PR tui/26638:
* gdb.tui/list.exp: Check output of "focus next".
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tui/26638] TUI focus behavior change
2020-09-20 0:56 [Bug tui/26638] New: TUI focus behavior change simark at simark dot ca
` (3 preceding siblings ...)
2020-09-24 19:02 ` cvs-commit at gcc dot gnu.org
@ 2020-09-24 19:04 ` cvs-commit at gcc dot gnu.org
2020-09-24 19:04 ` tromey at sourceware dot org
2020-09-24 19:05 ` tromey at sourceware dot org
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-24 19:04 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26638
--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-10-branch branch has been updated by Tom Tromey
<tromey@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8ccf2a20fbfe4b4a4199709b999ce3b601a9065a
commit 8ccf2a20fbfe4b4a4199709b999ce3b601a9065a
Author: Tom Tromey <tromey@adacore.com>
Date: Wed Sep 23 12:57:19 2020 -0600
Don't let TUI focus on locator
PR tui/26638 notes that the C-x o binding can put the focus on the
locator window. However, this is not useful and did not happen
historically. This patch changes the TUI to skip this window when
switching focus.
2020-09-24 Tom Tromey <tromey@adacore.com>
PR tui/26638:
* tui/tui-stack.h (struct tui_locator_window) <can_focus>: New
method.
* tui/tui-data.h (struct tui_win_info) <can_focus>: New method.
* tui/tui-data.c (tui_next_win): Exclude non-focusable windows.
(tui_prev_win): Rewrite.
gdb/testsuite/ChangeLog
2020-09-24 Tom Tromey <tromey@adacore.com>
PR tui/26638:
* gdb.tui/list.exp: Check output of "focus next".
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tui/26638] TUI focus behavior change
2020-09-20 0:56 [Bug tui/26638] New: TUI focus behavior change simark at simark dot ca
` (4 preceding siblings ...)
2020-09-24 19:04 ` cvs-commit at gcc dot gnu.org
@ 2020-09-24 19:04 ` tromey at sourceware dot org
2020-09-24 19:05 ` tromey at sourceware dot org
6 siblings, 0 replies; 8+ messages in thread
From: tromey at sourceware dot org @ 2020-09-24 19:04 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26638
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |NOTABUG
Status|NEW |RESOLVED
--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tui/26638] TUI focus behavior change
2020-09-20 0:56 [Bug tui/26638] New: TUI focus behavior change simark at simark dot ca
` (5 preceding siblings ...)
2020-09-24 19:04 ` tromey at sourceware dot org
@ 2020-09-24 19:05 ` tromey at sourceware dot org
6 siblings, 0 replies; 8+ messages in thread
From: tromey at sourceware dot org @ 2020-09-24 19:05 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26638
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|NOTABUG |FIXED
--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
Don't know why it switched to "notabug".
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-24 19:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-20 0:56 [Bug tui/26638] New: TUI focus behavior change simark at simark dot ca
2020-09-20 14:32 ` [Bug tui/26638] " brobecker at gnat dot com
2020-09-23 18:47 ` tromey at sourceware dot org
2020-09-23 18:59 ` tromey at sourceware dot org
2020-09-24 19:02 ` cvs-commit at gcc dot gnu.org
2020-09-24 19:04 ` cvs-commit at gcc dot gnu.org
2020-09-24 19:04 ` tromey at sourceware dot org
2020-09-24 19:05 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).