[Bug tui/26719] New: Source code disappears when switching focus

[Bug tui/26719] New: Source code disappears when switching focus

[simark at simark dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=26719

            Bug ID: 26719
           Summary: Source code disappears when switching focus
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: simark at simark dot ca
  Target Milestone: ---

At commit f511427204f281bc6278bb1facf6493518300806 ("gold: Update
testsuite/split_[i386|x32|x86_64].sh"), I get this bug:

1. start gdb on some program
2. ctrl-x a (to enable TUI, you should now see source code in the top panel)
3. ctrl-x o (to switch focus to the prompt)

When doing step 3, the source code disappears and shows "No Source Available".

The first commit to have this bug is 9e820dec13ec153f5843a30afe6d1c5037405278
("Use a curses pad for source and disassembly windows").

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/26719] Source code disappears when switching focus

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26719

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/26719] Source code disappears when switching focus

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26719

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2020-October/172471.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/26719] Source code disappears when switching focus

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26719

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=22cc388e2b940608d4d759dc61c0335cfc621de1

commit 22cc388e2b940608d4d759dc61c0335cfc621de1
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Oct 19 07:45:05 2020 -0600

    Don't erase TUI source window when switching focus

    PR tui/26719 points out that switching the focus can erase the TUI
    source window.  This is a regression introduced by the patch to switch
    the source window to using a pad.

    This patch fixes the bug by arranging to call prefresh whenever the
    window is refreshed.

    2020-10-19  Tom Tromey  <tromey@adacore.com>

            PR tui/26719
            * tui/tui-winsource.h (struct tui_source_window_base)
            <refresh_window>: Rename from refresh_pad.
            * tui/tui-winsource.c (tui_source_window_base::refresh_window):
            Rename from refresh_pad.
            (tui_source_window_base::show_source_content)
            (tui_source_window_base::do_scroll_horizontal): Update.

    gdb/testsuite/ChangeLog
    2020-10-19  Tom Tromey  <tromey@adacore.com>

            PR tui/26719
            * gdb.tui/list.exp: Check source window contents after focus
            change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/26719] Source code disappears when switching focus

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26719

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.1
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.