[Bug gdb/26768] New: [gdb] Import readline copy

[Bug gdb/26768] New: [gdb] Import readline copy

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26768

            Bug ID: 26768
           Summary: [gdb] Import readline copy
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

Our current readline version is 8.0 patchlevel 4.

Readline-8.1-rc1 has been out since two weeks, and an 8.1 release is expected.

I've been told that preliminary testing of gdb against a libreadline build from
Readline-8.1-rc1 shows that the problem for which this:
...
2019-07-12  Tom de Vries  <tdevries@suse.de>
            Chet Ramey  <chet.ramey@case.edu>

        PR cli/24514
        * readline/display.c (init_line_structures, rl_redisplay): Ensure
        line_size is at least _rl_screenwidth + 1.
...
was committed not longer occurs, so presumably that commit can be dropped when
doing the import, and perhaps also the followup commit:
...
2019-10-23  Andrew Burgess  <andrew.burgess@embecosm.com>

        PR cli/24980
        * display.c (init_line_structures): Initialise line_state using
        original minsize value.
...

FWIW, to reproduce the heap-buffer-overflow:
...
$ ASAN_OPTIONS=alloc_dealloc_mismatch=0 LD_PRELOAD=/usr/lib64/libasan.so.6
TERM="dumb" gdb -ex "set width 0"
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26768] [gdb] Import readline copy

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26768

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
8.1 is in the repository now, but the follow-up work remains to be done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26768] [gdb] Import readline copy

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26768

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ssbssa at sourceware dot org

--- Comment #2 from Hannes Domani <ssbssa at sourceware dot org> ---
Is there still something to be done here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/26768] [gdb] Import readline copy

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26768

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
We could probably import 8.2 now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.