[Bug gdb/26819] RISC-V: internal-error: int finish_step_over(execution_control_state*): Assertion

["simon.marchi at polymtl dot ca" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=26819

--- Comment #26 from Simon Marchi <simon.marchi at polymtl dot ca> ---
Hi Jan,

(off list) 

I just went into paternity leave, so I will probably won't be able to take a
look before a few weeks.  If you want to submit the patch for merging and get a
review, please send it to the gdb-patches list as described here.

https://sourceware.org/gdb/wiki/ContributionChecklist

Thanks,

Simon 

On February 7, 2021 4:20:24 PM EST, jmatyas at codasip dot com
<sourceware-bugzilla@sourceware.org> wrote:
>https://sourceware.org/bugzilla/show_bug.cgi?id=26819
>
>--- Comment #25 from Jan Matyas <jmatyas at codasip dot com> ---
>(In reply to Simon Marchi from comment #24)
>> [...]  The steps missing are:
>> 
>> - Write a good commit message that explains why things fail currently
>and
>> why the patch fixes them (including a ChangeLog entry)
>> - Enhance the test (gdb.server/stop-reply-no-thread.exp I think) so
>it
>> covers the two scenarios I mentioned ("--disable-packet=T
>> --disable-packet=qfThreadInfo" and "--disable-packet=threads")
>> - Send the patch to the mailing list for review.
>
>Hi Simon,
>I have rebased your patch from Jan-17 and enhanced the test case as
>suggested.
>Please, check if that is all right.
>
>As my knowledge of gdb code is low, I'd appreciate if you could write
>the
>commit message as the author of the patch (and submit it to the mailing
>list).
>
>Thank you, regards,
>Jan
>
>
>
>From c99eb5f06a0c25129875ed5addcc2cf2e7a9ab39 Mon Sep 17 00:00:00 2001
>From: Jan Matyas <jmatyas@codasip.com>
>Date: Sun, 7 Feb 2021 22:04:50 +0100
>Subject: [PATCH] Patch for gdb/26819
>
>TODO: Proper commit message
>
>- Rebased Simon Marchi's patch from Jan/17.
>- Extended the gdb.server/stop-reply-no-thread.exp test case
>  to cover the situation when the gdbserver does not report
>  any threads.
>---
> gdb/remote.c                                      | 9 ++++++---
> gdb/testsuite/gdb.server/stop-reply-no-thread.exp | 9 +++++++++
> 2 files changed, 15 insertions(+), 3 deletions(-)
>
>diff --git a/gdb/remote.c b/gdb/remote.c
>index 31c6e17a1c..4cda15470e 100644
>--- a/gdb/remote.c
>+++ b/gdb/remote.c
>@@ -741,7 +741,7 @@ class remote_target : public process_stratum_target
>   int remote_resume_with_vcont (ptid_t ptid, int step,
>                                gdb_signal siggnal);
>
>-  void add_current_inferior_and_thread (const char *wait_status);
>+  thread_info *add_current_inferior_and_thread (const char
>*wait_status);
>
>   ptid_t wait_ns (ptid_t ptid, struct target_waitstatus *status,
>                  target_wait_flags options);
>@@ -4411,7 +4411,7 @@ remote_target::get_current_thread (const char
>*wait_status)
>    qC query, we infer the current thread from that stop reply, passed
>    in in WAIT_STATUS, which may be NULL.  */
>
>-void
>+thread_info *
>remote_target::add_current_inferior_and_thread (const char
>*wait_status)
> {
>   struct remote_state *rs = get_remote_state ();
>@@ -4445,6 +4445,8 @@ remote_target::add_current_inferior_and_thread
>(const
>char *wait_status)
>      yet.  */
>   thread_info *tp = add_thread_silent (this, curr_ptid);
>   switch_to_thread_no_regs (tp);
>+
>+  return tp;
> }
>
> /* Print info about a thread that was found already stopped on
>@@ -4800,7 +4802,8 @@ remote_target::start_remote (int from_tty, int
>extended_p)
>          /* Target has no concept of threads at all.  GDB treats
>             non-threaded target as single-threaded; add a main
>             thread.  */
>-         add_current_inferior_and_thread (wait_status);
>+         thread_info *tp = add_current_inferior_and_thread
>(wait_status);
>+         get_remote_thread_info (tp)->set_resumed ();
>        }
>       else
>        {
>diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
>b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
>index 68bf42ac1a..e698eaff6e 100644
>--- a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
>+++ b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
>@@ -112,3 +112,12 @@ foreach_with_prefix to_disable { "" Tthread T } {
>        run_test $to_disable $t_nonstop
>     }
> }
>+
>+# Regression for gdb/26819: Cover the case when GDBserver does not
>report
>+# any threads. Non-stop Mode is off.
>+#
>+# Scenario 1: Disable 'T' and 'qfThreadInfo' packets
>+# Scenario 2: Disable all threading packets
>+foreach_with_prefix to_disable { "T,qfThreadInfo" "threads" } {
>+    run_test $to_disable off
>+}
>-- 
>2.20.1
>
>-- 
>You are receiving this mail because:
>You are on the CC list for the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.