[Bug ada/26903] New: FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[Bug ada/26903] New: FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

            Bug ID: 26903
           Summary: FAIL: gdb.ada/array_of_variant.exp: scenario=minimal:
                    print entire array
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ada
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

With current trunk I see these FAILS:
...
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array element
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array slice
...
as reported here (
https://sourceware.org/pipermail/gdb-patches/2020-November/173035.html ).

This fails with gnatmake 7.5.0, but passes starting gnatmake 8.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
FAILs in more detail:
...
(gdb) print objects^M
$1 = ((tag => object, values => ()), (tag => unused))^M
(gdb) FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array
print objects(1)^M
$2 = (tag => object, values => ())^M
(gdb) FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array
element
print objects(1 .. 1)^M
$3 = ((tag => object, values => ()))^M
(gdb) FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array
slice
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 12957
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12957&action=edit
ada exec

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 12958
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12958&action=edit
readelf -w output for exec

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 12959
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12959&action=edit
ada exec, gcc 8

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 12964
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12964&action=edit
readelf -w output for exec, gcc 8

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> With current trunk I see these FAILS:
> ...
> FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array
> FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array
> element
> FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array slice
> ...

And starting with:
...
commit cc9d6997a5b23d0c8e1960f6c0b5f5cdf456d4e9
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Jun 18 13:08:33 2021 -0600

    Fix array stride bug
...
we have:
...
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array element
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array slice
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: python print array
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: python print first array
element
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #6)
> (In reply to Tom de Vries from comment #0)
> > With current trunk I see these FAILS:
> > ...
> > FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array
> > FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array
> > element
> > FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array slice
> > ...
> 
> And starting with:
> ...
> commit cc9d6997a5b23d0c8e1960f6c0b5f5cdf456d4e9
> Author: Tom Tromey <tromey@adacore.com>
> Date:   Fri Jun 18 13:08:33 2021 -0600
> 
>     Fix array stride bug
> ...
> we have:
> ...
> FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array
> FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array
> element
> FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array slice
> FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: python print array
> FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: python print first
> array element
> ...

FTR, as mentioned before this is with gcc 7.5.0, all pass with gcc 8.4.0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> With current trunk I see these FAILS:
> ...
> FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

I looked into this one.  With gcc-8 we have:
...
 <1><1769>: Abbrev Number: 21 (DW_TAG_array_type)
    <176a>   DW_AT_name        : (indirect string, offset: 0x20ad): p__array_t
    <176e>   DW_AT_type        : <0x1758>
    <1772>   DW_AT_sibling     : <0x1781>
 <2><1776>: Abbrev Number: 22 (DW_TAG_subrange_type)
    <1777>   DW_AT_type        : <0x1751>
    <177b>   DW_AT_upper_bound : 4 byte block: 91 b8 7f 6       (DW_OP_fbreg:
-72; DW_OP_deref)
 <2><1780>: Abbrev Number: 0
...
but with gcc-7:
...
 <1><9a5>: Abbrev Number: 22 (DW_TAG_array_type)
    <9a6>   DW_AT_name        : (indirect string, offset: 0xd90): p__array_t
    <9aa>   DW_AT_type        : <0x994>
    <9ae>   DW_AT_sibling     : <0x9b8>
 <2><9b2>: Abbrev Number: 23 (DW_TAG_subrange_type)
    <9b3>   DW_AT_type        : <0x98d>
 <2><9b7>: Abbrev Number: 0
...

So, the DW_AT_upper_bound is missing, IWO this looks like an xfail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #9 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #8)
> So, the DW_AT_upper_bound is missing, IWO this looks like an xfail.

Stops failing at:
...
$ git show 51f01fc387a2fb580108ccb27f945ee4bd1cfd34          
commit 51f01fc387a2fb580108ccb27f945ee4bd1cfd34 (HEAD, refs/bisect
/bad)
Author: Richard Biener <rguenther@suse.de>
Date:   Tue May 16 11:00:59 2017 +0000

    dwarf2out.c (loc_list_from_tree_1): Do not create DW_OP_GNU_variable_value
for DECL_IGNORE
D_P decls.

    2017-05-16  Richard Biener  <rguenther@suse.de>

            * dwarf2out.c (loc_list_from_tree_1): Do not create
            DW_OP_GNU_variable_value for DECL_IGNORED_P decls.

    From-SVN: r248094
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #10 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #9)
> (In reply to Tom de Vries from comment #8)
> > So, the DW_AT_upper_bound is missing, IWO this looks like an xfail.
> 
> Stops failing at:
> ...
> $ git show 51f01fc387a2fb580108ccb27f945ee4bd1cfd34          
> commit 51f01fc387a2fb580108ccb27f945ee4bd1cfd34 (HEAD, refs/bisect
> /bad)
> Author: Richard Biener <rguenther@suse.de>
> Date:   Tue May 16 11:00:59 2017 +0000
> 
>     dwarf2out.c (loc_list_from_tree_1): Do not create
> DW_OP_GNU_variable_value for DECL_IGNORE
> D_P decls.
>     
>     2017-05-16  Richard Biener  <rguenther@suse.de>
>     
>             * dwarf2out.c (loc_list_from_tree_1): Do not create
>             DW_OP_GNU_variable_value for DECL_IGNORED_P decls.
>     
>     From-SVN: r248094
> ...

Filed gcc PR https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101633 "[debug]
DW_TAG_subrange_type missing DW_AT_upper_bound" as FTR PR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ada                         |testsuite

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #11 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=af2b87e649bc50407ecc230929bed9b3df1f4d03

commit af2b87e649bc50407ecc230929bed9b3df1f4d03
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Jul 27 16:56:23 2021 +0200

    [gdb/testsuite] Add xfail for PR gcc/101633

    With gcc 7.5.0, I run into:
    ...
    (gdb) print objects^M
    $1 = ((tag => object, values => ()), (tag => unused))^M
    (gdb) FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire
array
    ...
    while with gcc 8.5.0 we have:
    ...
    (gdb) print objects^M
    $1 = ((tag => object, values => (2, 2, 2, 2, 2)), (tag => unused))^M
    (gdb) PASS: gdb.ada/array_of_variant.exp: scenario=minimal: print entire
array
    ...

    This is due to a gcc PR, which I've filed at
    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101633 "Bug 101633 - [debug]
    DW_TAG_subrange_type missing DW_AT_upper_bound".

    Fix by marking this and related FAILs as XFAIL.

    Tested on x86_64-linux.

    gdb/ChangeLog:

    2021-07-27  Tom de Vries  <tdevries@suse.de>

            PR testsuite/26903
            * gdb/testsuite/gdb.ada/array_of_variant.exp: Add xfails.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

--- Comment #12 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-11-branch branch has been updated by Tom de Vries
<vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7e292f1ab8f9d5df484ffd14ca73245da2bcef21

commit 7e292f1ab8f9d5df484ffd14ca73245da2bcef21
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Jul 27 17:14:17 2021 +0200

    [gdb/testsuite] Add xfail for PR gcc/101633

    With gcc 7.5.0, I run into:
    ...
    (gdb) print objects^M
    $1 = ((tag => object, values => ()), (tag => unused))^M
    (gdb) FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire
array
    ...
    while with gcc 8.5.0 we have:
    ...
    (gdb) print objects^M
    $1 = ((tag => object, values => (2, 2, 2, 2, 2)), (tag => unused))^M
    (gdb) PASS: gdb.ada/array_of_variant.exp: scenario=minimal: print entire
array
    ...

    This is due to a gcc PR, which I've filed at
    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101633 "Bug 101633 - [debug]
    DW_TAG_subrange_type missing DW_AT_upper_bound".

    Fix by marking this and related FAILs as XFAIL.

    Tested on x86_64-linux.

    gdb/ChangeLog:

    2021-07-27  Tom de Vries  <tdevries@suse.de>

            PR testsuite/26903
            * gdb/testsuite/gdb.ada/array_of_variant.exp: Add xfails.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26903] FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26903

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.1
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch adding xfail added to trunk and gdb-11-branch, marking resolved-fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.