[Bug tui/26927] New: TUI's source window overflows if too small

[Bug tui/26927] New: TUI's source window overflows if too small

[simark at simark dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=26927

            Bug ID: 26927
           Summary: TUI's source window overflows if too small
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: simark at simark dot ca
  Target Milestone: ---

If the terminal (and therefore the source window) is small enough in height, it
overflows onto its own bottom border when drawn.  See attached screenshot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/26927] TUI's source window overflows if too small

[simark at simark dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=26927

--- Comment #1 from Simon Marchi <simark at simark dot ca> ---
Created attachment 12981
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12981&action=edit
Screenshot

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/26927] TUI's source window overflows if too small

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26927

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ssbssa at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/26927] TUI's source window overflows if too small

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26927

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hannes Domani <ssbssa@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b5ff370e964a5a794a6b5791ca55ac103ebffe70

commit b5ff370e964a5a794a6b5791ca55ac103ebffe70
Author: Hannes Domani <ssbssa@yahoo.de>
Date:   Mon Dec 21 13:16:24 2020 +0100

    Fix TUI source window drawing

    The smaxrow and smaxcol parameters of prefresh are the bottom right corner
    of the text area inclusive, not exclusive.

    And if the source window grows bigger in height, the pad has to grow as
    well.

    gdb/ChangeLog:

    2021-01-05  Hannes Domani  <ssbssa@yahoo.de>

            PR tui/26927
            * tui/tui-winsource.c (tui_source_window_base::refresh_window):
            Fix source pad size in prefresh.
            (tui_source_window_base::show_source_content): Grow source pad
            if necessary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/26927] TUI's source window overflows if too small

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26927

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |11.1
         Resolution|---                         |FIXED

--- Comment #3 from Hannes Domani <ssbssa at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.