public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/26954] New: FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!)
@ 2020-11-26 14:58 vries at gcc dot gnu.org
2020-11-26 16:59 ` [Bug testsuite/26954] " vries at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: vries at gcc dot gnu.org @ 2020-11-26 14:58 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26954
Bug ID: 26954
Summary: FAIL: gdb.base/float128.exp: print large128 (GDB may
be missing MPFR support!)
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: testsuite
Assignee: unassigned at sourceware dot org
Reporter: vries at gcc dot gnu.org
Target Milestone: ---
Indeed:
...
$ ./gdb -configuration | grep -i mpfr
--without-mpfr
...
On another gdb where the test passes:
...
$ ./gdb --configuration | grep mpfr
--with-mpfr
...
This shouldn't be FAIL, just unsupported or some such.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/26954] FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!)
2020-11-26 14:58 [Bug testsuite/26954] New: FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!) vries at gcc dot gnu.org
@ 2020-11-26 16:59 ` vries at gcc dot gnu.org
2020-12-10 12:54 ` vries at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: vries at gcc dot gnu.org @ 2020-11-26 16:59 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26954
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Tentative patch:
...
diff --git a/gdb/testsuite/gdb.base/float128.exp
b/gdb/testsuite/gdb.base/float128.exp
index 40babca..9508982 100644
--- a/gdb/testsuite/gdb.base/float128.exp
+++ b/gdb/testsuite/gdb.base/float128.exp
@@ -32,6 +32,16 @@ if { [do_compile] != "" && [do_compile {-mfloat128}] != "" }
{
clean_restart ${binfile}
+set mpfr_supported -1
+gdb_test_multiple "show configuration" "" {
+ -wrap -re "--with-mpfr\r\n.*" {
+ set mpfr_supported 1
+ }
+ -wrap -re "--without-mpfr\r\n.*" {
+ set mpfr_supported 0
+ }
+}
+
if ![runto_main] then {
perror "couldn't run to breakpoint"
continue
@@ -84,7 +94,11 @@ gdb_test_multiple "print large128" "$test" {
pass "$test"
}
-re ".* = inf.*$gdb_prompt $" {
- fail "$test (GDB may be missing MPFR support!)"
+ if { $mpfr_supported == 0 } {
+ unsupported "$test (Missing MPFR support)"
+ } else {
+ fail $test
+ }
}
-re ".*$gdb_prompt $" {
fail "$test"
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/26954] FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!)
2020-11-26 14:58 [Bug testsuite/26954] New: FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!) vries at gcc dot gnu.org
2020-11-26 16:59 ` [Bug testsuite/26954] " vries at gcc dot gnu.org
@ 2020-12-10 12:54 ` vries at gcc dot gnu.org
2020-12-11 12:55 ` cvs-commit at gcc dot gnu.org
2020-12-11 12:55 ` vries at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: vries at gcc dot gnu.org @ 2020-12-10 12:54 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26954
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
patch submitted:
https://sourceware.org/pipermail/gdb-patches/2020-December/173972.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/26954] FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!)
2020-11-26 14:58 [Bug testsuite/26954] New: FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!) vries at gcc dot gnu.org
2020-11-26 16:59 ` [Bug testsuite/26954] " vries at gcc dot gnu.org
2020-12-10 12:54 ` vries at gcc dot gnu.org
@ 2020-12-11 12:55 ` cvs-commit at gcc dot gnu.org
2020-12-11 12:55 ` vries at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-12-11 12:55 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26954
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9cd7a95a2bb9ba9d5a6af022e5454c8ce78aee56
commit 9cd7a95a2bb9ba9d5a6af022e5454c8ce78aee56
Author: Tom de Vries <tdevries@suse.de>
Date: Fri Dec 11 13:55:04 2020 +0100
[gdb/testsuite] Fix gdb.base/float128.exp with --with-mpfr=no
When configuring gdb using --with-mpfr=no and running test-case
gdb.base/float128.exp, we run into:
...
FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR
support!)
...
Fix this by detecting that gdb was build without mpfr using the show
configuration command, and changing the FAIL into UNSUPPORTED.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2020-12-11 Tom de Vries <tdevries@suse.de>
PR testsuite/26954
* gdb.base/float128.exp: Detect and handle no mpfr support.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/26954] FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!)
2020-11-26 14:58 [Bug testsuite/26954] New: FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!) vries at gcc dot gnu.org
` (2 preceding siblings ...)
2020-12-11 12:55 ` cvs-commit at gcc dot gnu.org
@ 2020-12-11 12:55 ` vries at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: vries at gcc dot gnu.org @ 2020-12-11 12:55 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26954
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Target Milestone|--- |11.1
Resolution|--- |FIXED
--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch fixing test-case committed, marking resolved-fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-11 12:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 14:58 [Bug testsuite/26954] New: FAIL: gdb.base/float128.exp: print large128 (GDB may be missing MPFR support!) vries at gcc dot gnu.org
2020-11-26 16:59 ` [Bug testsuite/26954] " vries at gcc dot gnu.org
2020-12-10 12:54 ` vries at gcc dot gnu.org
2020-12-11 12:55 ` cvs-commit at gcc dot gnu.org
2020-12-11 12:55 ` vries at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).