public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug gdb/27528] New: compile fail (binutils/gdb/ada-lang.c)
@ 2021-03-05 21:48 klen_s at mail dot ru
2021-03-05 21:52 ` [Bug gdb/27528] " klen_s at mail dot ru
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: klen_s at mail dot ru @ 2021-03-05 21:48 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27528
Bug ID: 27528
Summary: compile fail (binutils/gdb/ada-lang.c)
Product: gdb
Version: HEAD
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: klen_s at mail dot ru
Target Milestone: ---
Created attachment 13292
--> https://sourceware.org/bugzilla/attachment.cgi?id=13292&action=edit
patch
build binutils with fail compile of binutils/gdb/ada-lang.c
sources: HEAD
configure args: src/binutils/configure -v
--prefix=/klen/tools/arm-kgp-eabi_@_x86_64-kgp-linux-gnu_westmere
--target=arm-kgp-eabi --host=x86_64-kgp-linux-gnu --build=x86_64-kgp-linux-gnu
--disable-werror --enable-multilib --with-pic --enable-nls --enable-lto
--enable-plugins --enable-static --disable-shared --with-expat --disable-sim
--enable-gold --enable--threads --disable-source-highlight
compiler output error:
CXX ada-lang.o
../../../src/bu-gdb/gdb/ada-lang.c: В функции «const char*
ada_fold_name(gdb::string_view)»:
../../../src/bu-gdb/gdb/ada-lang.c:947:64: ошибка: нет соответствующей функции
для вызова «to_string(std::basic_string_view<char>)»
947 | fold_storage = to_string (name.substr (1, name.size () - 2));
| ^
In file included from
/klen/tools/x86_64-kgp-linux-gnu-znver2-avx2/lib/gcc/x86_64-kgp-linux-gnu/11.0.1/include/c++/string:55,
from ../../../src/bu-gdb/gdb/../gdbsupport/common-utils.h:23,
from ../../../src/bu-gdb/gdb/../gdbsupport/common-defs.h:125,
from ../../../src/bu-gdb/gdb/defs.h:28,
from ../../../src/bu-gdb/gdb/ada-lang.c:21:
patch:
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index bb50222f81..8f27f3ccdf 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -944,10 +944,10 @@ ada_fold_name (gdb::string_view name)
static std::string fold_storage;
if (!name.empty () && name[0] == '\'')
- fold_storage = to_string (name.substr (1, name.size () - 2));
+ fold_storage = gdb::to_string (name.substr (1, name.size () - 2));
else
{
- fold_storage = to_string (name);
+ fold_storage = gdb::to_string (name);
for (int i = 0; i < name.size (); i += 1)
fold_storage[i] = tolower (fold_storage[i]);
}
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug gdb/27528] compile fail (binutils/gdb/ada-lang.c)
2021-03-05 21:48 [Bug gdb/27528] New: compile fail (binutils/gdb/ada-lang.c) klen_s at mail dot ru
@ 2021-03-05 21:52 ` klen_s at mail dot ru
2021-03-06 16:43 ` cvs-commit at gcc dot gnu.org
2021-03-06 16:43 ` tromey at sourceware dot org
2 siblings, 0 replies; 4+ messages in thread
From: klen_s at mail dot ru @ 2021-03-05 21:52 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27528
--- Comment #1 from Chernov Sergey aka Klen <klen_s at mail dot ru> ---
Helow from caxara.ru
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug gdb/27528] compile fail (binutils/gdb/ada-lang.c)
2021-03-05 21:48 [Bug gdb/27528] New: compile fail (binutils/gdb/ada-lang.c) klen_s at mail dot ru
2021-03-05 21:52 ` [Bug gdb/27528] " klen_s at mail dot ru
@ 2021-03-06 16:43 ` cvs-commit at gcc dot gnu.org
2021-03-06 16:43 ` tromey at sourceware dot org
2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-06 16:43 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27528
--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=01573d7360cdd9660fdc6bf48b0b7f2180f5c40c
commit 01573d7360cdd9660fdc6bf48b0b7f2180f5c40c
Author: Tom Tromey <tom@tromey.com>
Date: Sat Mar 6 09:38:26 2021 -0700
Fix build bug in ada-lang.c
An earlier patch of mine introduced a build failure in ada-lang.c. A
couple of "to_string" calls were not namespace-qualified. In the
failing setup, the std string_view is being used, and so (apparently)
ADL doesn't find gdb::to_string.
This patch, from the bug, fixes the problem.
gdb/ChangeLog
2021-03-06 Chernov Sergey <klen_s@mail.ru>
PR gdb/27528:
* ada-lang.c (ada_fold_name): Use gdb::to_string.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug gdb/27528] compile fail (binutils/gdb/ada-lang.c)
2021-03-05 21:48 [Bug gdb/27528] New: compile fail (binutils/gdb/ada-lang.c) klen_s at mail dot ru
2021-03-05 21:52 ` [Bug gdb/27528] " klen_s at mail dot ru
2021-03-06 16:43 ` cvs-commit at gcc dot gnu.org
@ 2021-03-06 16:43 ` tromey at sourceware dot org
2 siblings, 0 replies; 4+ messages in thread
From: tromey at sourceware dot org @ 2021-03-06 16:43 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27528
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org
Resolution|--- |FIXED
Target Milestone|--- |11.1
Status|UNCONFIRMED |RESOLVED
--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Thanks for the patch.
I checked it in.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-06 16:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 21:48 [Bug gdb/27528] New: compile fail (binutils/gdb/ada-lang.c) klen_s at mail dot ru
2021-03-05 21:52 ` [Bug gdb/27528] " klen_s at mail dot ru
2021-03-06 16:43 ` cvs-commit at gcc dot gnu.org
2021-03-06 16:43 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).