public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/27681] FAIL: gdb.base/help.exp: apropos \(print[^[ bsiedf\".-]\) (timeout)
Date: Thu, 08 Apr 2021 09:44:20 +0000	[thread overview]
Message-ID: <bug-27681-4717-e458Wmnxwx@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27681-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27681

--- Comment #21 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Michael Matz from comment #18)
> The types are simply incompatible:
> 
> extern int regcomp (regex_t *_Restrict_ __preg,
>                     const char *_Restrict_ __pattern,
>                     int __cflags);
> ...
> extern regoff_t re_search (struct re_pattern_buffer *__buffer,
>                            const char *__String, regoff_t __length,
>                            regoff_t __start, regoff_t __range,
>                            struct re_registers *__regs);
> 
> regex_t != struct re_pattern_buffer.  In the GNU implementation they are a
> typedef
> of each other 

Right, and that typedef in a user-interfacing header file was precisely the
reason it looked obvious to me that the types were compatible.  So thanks for
making a detailed argument, now I understand the difference in interpretation.

> (which is why there are no warnings :-/ ).

Yeah, if these types were designed to be incompatible, the implementation has a
certain invitation-to-shoot-yourself-in-the-foot quality about it.

> But conceptually
> it's two opaque (and different) types

Agreed, that could be a valid point that I overlooked.  If so, the
incompatibility might deserve a mention at the typedef, especially since there
is at least one function (regfree) that does exploit that typedef.

Anyway, after finding this (
https://www.gnu.org/software/gnulib/manual/html_node/GNU-Regex-Functions.html#GNU-Regex-Functions
) it seems that this is the documentation I've been looking for.  It lists a
set of functions that can be used together.  There's only one function from the
posix interface explicitly listed: regfree.  This corroborates your point that
the types are meant to be incompatible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-04-08  9:44 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  9:46 [Bug gdb/27681] New: " vries at gcc dot gnu.org
2021-04-01  9:50 ` [Bug gdb/27681] " vries at gcc dot gnu.org
2021-04-01 10:06 ` vries at gcc dot gnu.org
2021-04-01 10:08 ` vries at gcc dot gnu.org
2021-04-01 11:38 ` vries at gcc dot gnu.org
2021-04-01 12:53 ` tromey at sourceware dot org
2021-04-01 13:16 ` vries at gcc dot gnu.org
2021-04-01 14:53 ` vries at gcc dot gnu.org
2021-04-02 11:17 ` vries at gcc dot gnu.org
2021-04-02 11:32 ` vries at gcc dot gnu.org
2021-04-03 13:08 ` vries at gcc dot gnu.org
2021-04-04  2:21 ` vries at gcc dot gnu.org
2021-04-06  8:53 ` schwab@linux-m68k.org
2021-04-06  9:00 ` vries at gcc dot gnu.org
2021-04-06  9:23 ` schwab@linux-m68k.org
2021-04-06 13:17 ` vries at gcc dot gnu.org
2021-04-06 14:03 ` matz at suse dot de
2021-04-06 14:12 ` vries at gcc dot gnu.org
2021-04-06 14:29 ` vries at gcc dot gnu.org
2021-04-06 15:51 ` matz at suse dot de
2021-04-07  2:51 ` tromey at sourceware dot org
2021-04-08  8:57 ` vries at gcc dot gnu.org
2021-04-08  9:44 ` vries at gcc dot gnu.org [this message]
2021-04-08 12:48 ` vries at gcc dot gnu.org
2021-04-08 12:56 ` matz at suse dot de
2021-04-08 13:10 ` tromey at sourceware dot org
2021-04-12 13:38 ` vries at gcc dot gnu.org
2021-04-13 15:35 ` vries at gcc dot gnu.org
2021-04-21 19:54 ` cvs-commit at gcc dot gnu.org
2021-04-21 19:55 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27681-4717-e458Wmnxwx@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).