public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/27681] FAIL: gdb.base/help.exp: apropos \(print[^[ bsiedf\".-]\) (timeout)
Date: Mon, 12 Apr 2021 13:38:54 +0000	[thread overview]
Message-ID: <bug-27681-4717-fw8HaJvTv6@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27681-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27681

--- Comment #25 from Tom de Vries <vries at gcc dot gnu.org> ---
I tried to look a bit into the history.

Timeline:
- 1989-01-31
  gdb-3.1 commit of binutils-gdb.git adds regex.c. Looks like gnu regex.c,
  has copyright 1985.
- 1992-11-08:
  Initial revision commit of gnulib.git adds regex.c copied from
  GNU regex 0.11. Copyright goes back to 1985.
- 1993-04-03 
  GNU regex 0.12 is released, final release
- 1995-05-18
  Glibc imports GNU regex, presumably from gnulib.
- 1996-05-14
  Last update regex.c from gnulib to glibc
- 1997-07-26
  Gnulib updates regex.c from glibc
- 2000-04-03
  gdb grows option to use regex from glibc
- 2001-07-11
  libiberty imports regex.c from gdb
  https://gcc.gnu.org/pipermail/gcc-patches/2001-May/050292.html
- 2001-09-01
  Gdb starts using libiberty regex implementation.
  https://sourceware.org/pipermail/gdb-patches/2001-September/010733.html
- 2003-01-02
  gdb switches to use regex from glibc by default, provided it's version 2.
  https://sourceware.org/pipermail/gdb-patches/2003-January/023377.html

(In reply to Tom Tromey from comment #24)
> I think there are a few routes forward:
> 
> 1. Change the code to conform to POSIX.  Fine by me.
> 

I'd prefer it to avoid this rewrite.  It just means you'd have to add
functionality somewhere that is already contained in gnu regex.  Sounds like
duplication of work to me.

> 2. Change the code to always use libiberty.  This requires understanding
>    why the alternative was ever made possible.
> 

I miss the option of using gnulib. We currently don't import that module, but
we could.

The commit that introduced the possibility in gdb to use glibc, had the
rationale that glibc was where gnu regex was then maintained.

AFAICT, the commit that changed the default to glibc assumed that that change
was already in place, but undone somehow. I didn't find any evidence in the
source for this, so I'm not sure if there ever was an actual decision taken
there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-04-12 13:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  9:46 [Bug gdb/27681] New: " vries at gcc dot gnu.org
2021-04-01  9:50 ` [Bug gdb/27681] " vries at gcc dot gnu.org
2021-04-01 10:06 ` vries at gcc dot gnu.org
2021-04-01 10:08 ` vries at gcc dot gnu.org
2021-04-01 11:38 ` vries at gcc dot gnu.org
2021-04-01 12:53 ` tromey at sourceware dot org
2021-04-01 13:16 ` vries at gcc dot gnu.org
2021-04-01 14:53 ` vries at gcc dot gnu.org
2021-04-02 11:17 ` vries at gcc dot gnu.org
2021-04-02 11:32 ` vries at gcc dot gnu.org
2021-04-03 13:08 ` vries at gcc dot gnu.org
2021-04-04  2:21 ` vries at gcc dot gnu.org
2021-04-06  8:53 ` schwab@linux-m68k.org
2021-04-06  9:00 ` vries at gcc dot gnu.org
2021-04-06  9:23 ` schwab@linux-m68k.org
2021-04-06 13:17 ` vries at gcc dot gnu.org
2021-04-06 14:03 ` matz at suse dot de
2021-04-06 14:12 ` vries at gcc dot gnu.org
2021-04-06 14:29 ` vries at gcc dot gnu.org
2021-04-06 15:51 ` matz at suse dot de
2021-04-07  2:51 ` tromey at sourceware dot org
2021-04-08  8:57 ` vries at gcc dot gnu.org
2021-04-08  9:44 ` vries at gcc dot gnu.org
2021-04-08 12:48 ` vries at gcc dot gnu.org
2021-04-08 12:56 ` matz at suse dot de
2021-04-08 13:10 ` tromey at sourceware dot org
2021-04-12 13:38 ` vries at gcc dot gnu.org [this message]
2021-04-13 15:35 ` vries at gcc dot gnu.org
2021-04-21 19:54 ` cvs-commit at gcc dot gnu.org
2021-04-21 19:55 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27681-4717-fw8HaJvTv6@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).