public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/27921] New: FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: gdb-index file created
@ 2021-05-27 10:24 vries at gcc dot gnu.org
  2021-05-27 13:22 ` [Bug testsuite/27921] " cvs-commit at gcc dot gnu.org
  2021-05-27 13:24 ` vries at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: vries at gcc dot gnu.org @ 2021-05-27 10:24 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=27921

            Bug ID: 27921
           Summary: FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: gdb-index
                    file created
           Product: gdb
           Version: 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

We run into trouble when running these two test-cases in this specific order:
...
$ make check 'RUNTESTFLAGS=gdb.dwarf2/gdb-index.exp
gdb.dwarf2/gdb-add-index-symlink.exp'

  ...

Running
/home/vries/gdb_versions/devel/src/gdb/testsuite/gdb.dwarf2/gdb-index.exp ...
Running
/home/vries/gdb_versions/devel/src/gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp
...
FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: gdb-index file created
FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: Unable to call gdb-add-index with a
symlink to a symfile

                === gdb Summary ===

# of expected passes            8
# of unexpected failures        2
...

The problem is that gdb-index.exp introduces a proc add_gdb_index which
overrides the one in lib/gdb.exp and stays active after the test is done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug testsuite/27921] FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: gdb-index file created
  2021-05-27 10:24 [Bug testsuite/27921] New: FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: gdb-index file created vries at gcc dot gnu.org
@ 2021-05-27 13:22 ` cvs-commit at gcc dot gnu.org
  2021-05-27 13:24 ` vries at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-05-27 13:22 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=27921

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e453275cdcb28f3ca70ecb90d7aec51272a7a4f9

commit e453275cdcb28f3ca70ecb90d7aec51272a7a4f9
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu May 27 15:22:38 2021 +0200

    [gdb/testsuite] Prevent proc override in gdb-index.exp

    When running these two test-cases in this specific order we get:
    ...
    $ make check 'RUNTESTFLAGS=gdb.dwarf2/gdb-index.exp \
        gdb.dwarf2/gdb-add-index-symlink.exp'
      ...
    Running gdb.dwarf2/gdb-index.exp ...
    Running gdb.dwarf2/gdb-add-index-symlink.exp ...
    FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: gdb-index file created
    FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: Unable to call \
      gdb-add-index with a symlink to a symfile
    ...

    The problem is that gdb-index.exp introduces a proc add_gdb_index which
    overrides the one in lib/gdb.exp and stays active after the test is done.
    Consequently it's used in gdb-add-index-symlink.exp, which should use the
one
    from lib/gdb.exp.

    Fix this by renaming proc add_gdb_index in gdb-index.exp.

    Tested on x86_64-linux.

    gdb/testsuite/ChangeLog:

    2021-05-27  Tom de Vries  <tdevries@suse.de>

            PR testsuite/27921
            * gdb.dwarf2/gdb-index.exp (add_gdb_index): Rename to ...
            (local_add_gdb_index): ... this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug testsuite/27921] FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: gdb-index file created
  2021-05-27 10:24 [Bug testsuite/27921] New: FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: gdb-index file created vries at gcc dot gnu.org
  2021-05-27 13:22 ` [Bug testsuite/27921] " cvs-commit at gcc dot gnu.org
@ 2021-05-27 13:24 ` vries at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: vries at gcc dot gnu.org @ 2021-05-27 13:24 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=27921

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |11.1
         Resolution|---                         |FIXED

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch committed, marking resolved-fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-27 13:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 10:24 [Bug testsuite/27921] New: FAIL: gdb.dwarf2/gdb-add-index-symlink.exp: gdb-index file created vries at gcc dot gnu.org
2021-05-27 13:22 ` [Bug testsuite/27921] " cvs-commit at gcc dot gnu.org
2021-05-27 13:24 ` vries at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).