[Bug gdb/28404] Verify bsearch precondition in find_pc_section

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=28404

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
I wrote this:
...
diff --git a/gdb/objfiles.c b/gdb/objfiles.c
index b65fa8820ca..cc9a47eaad8 100644
--- a/gdb/objfiles.c
+++ b/gdb/objfiles.c
@@ -1227,6 +1227,19 @@ find_pc_section (CORE_ADDR pc)
       return NULL;
     }

+  {
+    struct obj_section *prev_elem = nullptr;
+    struct obj_section *elem = nullptr;
+    for (int i = 0; i < pspace_info->num_sections; (prev_elem = elem), ++i)

+      {
+       elem = pspace_info->sections[i];
+       gdb_assert (elem->addr () <= elem->endaddr ());
+       if (prev_elem == nullptr)
+         continue;
+       gdb_assert (prev_elem->endaddr () <= elem->addr ());
+      }
+  }re--
+
   sp = (struct obj_section **) bsearch (&pc,
                                        pspace_info->sections,
                                        pspace_info->num_sections,
... 

And tested using target board unix/-fPIE/-pie.  No regression.

So, I guess I was looking at the consequences of the patch series I was playing
around with.

-- 
You are receiving this mail because:
You are on the CC list for the bug.