[Bug tui/28437] New: `fs status` followed by `fs next` fails to switch focus on Mac

[Bug tui/28437] New: `fs status` followed by `fs next` fails to switch focus on Mac

[sourceware at fastmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28437

            Bug ID: 28437
           Summary: `fs status` followed by `fs next` fails to switch
                    focus on Mac
           Product: gdb
           Version: 10.1
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: sourceware at fastmail dot com
  Target Milestone: ---

GDB 10.2 installed from macports, NOT 10.1 (but I don't see it in the list)

Switching focus in tui mode breaks.
To repro:

```
$ gdb -tui ./baseq3/cpma/bin/a.out
Reading symbols from ./baseq3/cpma/bin/a.out...
Reading symbols from
/Applications/ioquake3/baseq3/cpma/bin/a.out.dSYM/Contents/Resources/DWARF/a.out...
(gdb) fs status
Focus set to status window.
(gdb) fs next
/opt/local/var/macports/build/_private_tmp_macports-ports_devel_gdb/gdb/work/gdb-10.2/gdb/tui/tui-data.c:116:
internal-error: struct tui_win_info *tui_next_win(struct tui_win_
info *): Assertion `cur_win->can_focus ()' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) y

This is a bug, please report it.  For instructions, see:
<https://www.gnu.org/software/gdb/bugs/>.

/opt/local/var/macports/build/_private_tmp_macports-ports_devel_gdb/gdb/work/gdb-10.2/gdb/tui/tui-data.c:116:
internal-error: struct tui_win_info *tui_next_win(struct tui_win_
info *): Assertion `cur_win->can_focus ()' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Create a core file of GDB? (y or n) yAbort trap: 6 (core dumped)
                                                                [Exit 134
(ABRT)]

```
This works with whatever code is being debugged, I repro with a hello world in
C


ADDITIONAL DETAILS
GDB 10.2 installed from macports
Mac OS X Big Sur 11.6
gcc 11.2.0_1 installed from macports
```
$ uname -a
Darwin macbook 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT
2021; root:xnu-7195.141.6~3/RELEASE_X86_64 x86_64 i386 MacBookPro11,4 Darwin
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/opt/local/libexec/gcc/x86_64-apple-darwin20/11.2.0/lto-wrapper
Target: x86_64-apple-darwin20
Configured with:
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_gcc11/gcc11/work/gcc-11.2.0/configure
--prefix=/opt/local --build=x86_64-apple-darwin20
--enable-languages=c,c++,objc,obj-c++,lto,fortran,jit
--libdir=/opt/local/lib/gcc11 --includedir=/opt/local/include/gcc11
--infodir=/opt/local/share/info --mandir=/opt/local/share/man
--datarootdir=/opt/local/share/gcc-11 --with-local-prefix=/opt/local
--with-system-zlib --disable-nls --program-suffix=-mp-11
--with-gxx-include-dir=/opt/local/include/gcc11/c++/ --with-gmp=/opt/local
--with-mpfr=/opt/local --with-mpc=/opt/local --with-isl=/opt/local
--enable-stage1-checking --disable-multilib --enable-lto
--enable-libstdcxx-time --with-build-config=bootstrap-debug
--with-bugurl=https://trac.macports.org/newticket --enable-host-shared
--disable-tls --with-as=/opt/local/bin/as --with-ld=/opt/local/bin/ld
--with-ar=/opt/local/bin/ar --with-pkgversion='MacPorts gcc11 11.2.0_1'
--with-sysroot=/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 11.2.0 (MacPorts gcc11 11.2.0_1)
$ gdb
(gdb) show config
(gdb) show config
This GDB was configured as follows:
   configure --host=x86_64-apple-darwin20.6.0
--target=x86_64-apple-darwin20.6.0
             --with-auto-load-dir=:${prefix}/share/auto-load
             --with-auto-load-safe-path=:${prefix}/share/auto-load
             --with-expat
             --with-gdb-datadir=/opt/local/share/gdb (relocatable)
             --with-jit-reader-dir=/opt/local/lib/gdb (relocatable)
             --without-libunwind-ia64
             --without-lzma
             --without-babeltrace
             --without-intel-pt
             --without-mpfr
             --without-xxhash
            
--with-python=/opt/local/Library/Frameworks/Python.framework/Versions/3.9
(relocatable)
            
--with-python-libdir=/opt/local/Library/Frameworks/Python.framework/Versions/3.9/lib
(relocatable)
             --without-debuginfod
             --without-guile
             --disable-source-highlight
             --with-separate-debug-dir=/opt/local/lib/debug (relocatable)
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/28437] Internal error with `fs status` followed by `fs next`

[simark at simark dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=28437

Simon Marchi <simark at simark dot ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simark at simark dot ca
            Summary|`fs status` followed by `fs |Internal error with `fs
                   |next` fails to switch focus |status` followed by `fs
                   |on Mac                      |next`

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/28437] Internal error with `fs status` followed by `fs next`

[simark at simark dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=28437

--- Comment #1 from Simon Marchi <simark at simark dot ca> ---
I reproduced it on Linux.  I changed the title to not say "mac" specifically,
and mention that we hit an internal error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/28437] Internal error with `fs status` followed by `fs next`

[sourceware at fastmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28437

--- Comment #2 from Julien <sourceware at fastmail dot com> ---
Also of note is that gdb was unable to produce a coredump, it just hung for a
few seconds and then bailed. It may possibly be related so I'll come back to
that and open a new bug if need be, once the focus-switch is fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/28437] Internal error with `fs status` followed by `fs next`

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28437

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.1
         Resolution|---                         |FIXED
                 CC|                            |tromey at sourceware dot org
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
> (gdb) fs status
> Focus set to status window.

I think this was fixed by:

commit 24f3aded1d42f515527e2de7e8e9e26f0b77c932
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Tue Dec 20 15:01:29 2022 +0000

    gdb/testsuite/tui: more testing of the 'focus' command

    I noticed that we didn't have many tests of the tui 'focus' command,
    so I started adding some.  This exposed a bug in GDB; we are able to
    focus windows that should not be focusable, e.g. the 'status' window.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/28437] Internal error with `fs status` followed by `fs next`

[free_software at fastmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28437

Julien <free_software at fastmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #4 from Julien <free_software at fastmail dot com> ---
I just checked with gdb 12.1, I'm afraid I'm still running into the problem:

```
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_gdb/gdb/work/gdb-12.1/gdb/tui/tui-data.c:116:
internal-error: tui_next_win: Assertion `cur_win->can_focus ()' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
----- Backtrace -----
                     error creating backtrace: executable file is not an
executable
                                                                               
   ---------------------

                                  For instructions, see:                       
                        This is a bug, please report it.
<https://www.gnu.org/software/gdb/bugs/>.
```

Is there a way to mark this as not fixed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/28437] Internal error with `fs status` followed by `fs next`

[free_software at fastmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28437

Julien <free_software at fastmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|VERIFIED                    |RESOLVED

--- Comment #5 from Julien <free_software at fastmail dot com> ---
Apologies, my previous comment might have been too hasty. I just checked and
noticed the referenced commit wasn't included in 12.1.

I'll come back to this once 13.1 is up and running on my computer. Moving this
back to RESOLVED FIXED - thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/28437] Internal error with `fs status` followed by `fs next`

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28437

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
It may only be in the release after that -- i.e., 14.1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.