[Bug build/28456] New: Compilation error in gdb/c-exp.y

[Bug build/28456] New: Compilation error in gdb/c-exp.y

[patrick at monnerat dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=28456

            Bug ID: 28456
           Summary: Compilation error in gdb/c-exp.y
           Product: gdb
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: patrick at monnerat dot net
  Target Milestone: ---

Building with bison 3.8.2 causes the following compilation error:

c-exp.y:3455:1: error 'void c_print_token(FILE*, int, YYSTYPE)' defined but not
used [-Werror=unused-function]

The reason is bison does not generate YYPRINT references since version 3.7.6:
%printer must be used instead.

Thanks or fixing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/28456] Compilation error in gdb/c-exp.y

[cbiesinger at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28456

Christian Biesinger <cbiesinger at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |cbiesinger at google dot com
   Last reconfirmed|                            |2021-10-15
                 CC|                            |cbiesinger at google dot com
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

--- Comment #1 from Christian Biesinger <cbiesinger at google dot com> ---
My patch for this is currently waiting for review:
https://sourceware.org/pipermail/gdb-patches/2021-October/182474.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/28456] Compilation error in gdb/c-exp.y

[patrick at monnerat dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=28456

--- Comment #2 from Patrick Monnerat <patrick at monnerat dot net> ---
> My patch for this is currently waiting for review

Thanks for taking care.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/28456] Compilation error in gdb/c-exp.y

[cbiesinger at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28456

Christian Biesinger <cbiesinger at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Christian Biesinger <cbiesinger at google dot com> ---
This has been pushed by simark.

commit 6d81986879bbb05407e17e4788c52195897011c0
Author:     Christian Biesinger <cbiesinger@google.com>
AuthorDate: Fri Oct 8 16:09:46 2021
Commit:     Simon Marchi <simon.marchi@efficios.com>
CommitDate: Wed Oct 20 11:11:54 2021

    Make c-exp.y work with Bison 3.8+

    When using Bison 3.8, we get this error:

        ../../gdb/c-exp.y:3455:1: error: 'void c_print_token(FILE*, int,
YYSTYPE)' defined but not used [-Werror=unused-function]

    That's because bison 3.8 removed YYPRINT support:
    https://savannah.gnu.org/forum/forum.php?forum_id=10047

    Accordingly, this patch only defines that function for Bison < 3.8.

    Change-Id: I3cbf2f317630bb72810b00f2d9b2c4b99fa812ad

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/28456] Compilation error in gdb/c-exp.y

[patrick at monnerat dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=28456

--- Comment #4 from Patrick Monnerat <patrick at monnerat dot net> ---
Works perfectly now. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.