public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tui/28482] [tui] nexting through hello world results in duplicate lines in source window
Date: Thu, 21 Oct 2021 08:23:50 +0000	[thread overview]
Message-ID: <bug-28482-4717-sHrvAhLmyZ@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28482-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28482

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
I switched off the reverse mode point highlighting:
...
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index afd51e95980..f0bf76b15be 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -239,13 +239,17 @@ tui_source_window_base::show_source_line (int lineno)
   struct tui_source_element *line;

   line = &m_content[lineno];
+#if 0
   if (line->is_exec_point)
     tui_set_reverse_mode (m_pad.get (), true);
+#endif

   wmove (m_pad.get (), lineno, 0);
   tui_puts (line->line.c_str (), m_pad.get ());
+#if 0
   if (line->is_exec_point)
     tui_set_reverse_mode (m_pad.get (), false);
+#endif
 }

 /* See tui-winsource.h.  */
...
and got instead:
...
     6  {
     7    void *p = malloc (10);
>    8    printf ("hello: %p\n", p);
     9    return 0;
>   10  }
...
which fixes the duplicate line, but the old '>' marker is left, and the new one
is in the wrong place.  After another next, we have:
...
     6  {
     7    void *p = malloc (10);
>    8    printf ("hello: %p\n", p);
     9    return 0;
    10  }
>   11
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2021-10-21  8:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21  8:16 [Bug tui/28482] New: " vries at gcc dot gnu.org
2021-10-21  8:23 ` vries at gcc dot gnu.org [this message]
2021-10-21  8:26 ` [Bug tui/28482] " vries at gcc dot gnu.org
2021-10-21  9:29 ` vries at gcc dot gnu.org
2021-10-21  9:39 ` vries at gcc dot gnu.org
2021-10-21 11:35 ` vries at gcc dot gnu.org
2021-10-21 13:09 ` vries at gcc dot gnu.org
2023-05-24 14:13 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28482-4717-sHrvAhLmyZ@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).